From: Eli Zaretskii <eliz@gnu.org>
To: "Clément Pit-Claudel" <cpitclaudel@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: Line height issues with display-line-number-mode
Date: Wed, 08 May 2019 21:25:52 +0300 [thread overview]
Message-ID: <83k1f0hkgf.fsf@gnu.org> (raw)
In-Reply-To: <fb150e54-4bca-ce9c-0a75-37c888f3f97a@gmail.com> (message from Clément Pit-Claudel on Wed, 8 May 2019 14:04:17 -0400)
> Cc: emacs-devel@gnu.org
> From: Clément Pit-Claudel <cpitclaudel@gmail.com>
> Date: Wed, 8 May 2019 14:04:17 -0400
>
> (with-current-buffer (get-buffer-create "*test*")
> (insert "test\ntest\ntest")
> (let ((ov (make-overlay 1 6))
> (str (concat (propertize " " 'display '(space :height (1) :align-to right) 'face '(:underline t))
> "AAA\n"
> "BBB"
> (propertize " " 'display '(space :height (1) :align-to right) 'face '(:underline t)))))
> (overlay-put ov 'after-string str)
> (overlay-put ov 'face '(:underline t)))
> (pop-to-buffer (current-buffer)))
>
> It works OK! But it has a few problems:
>
> * The underline is thicker under the first 'test' than under the rest of the line. It seems to work better if I don't put the :underline property on the overlay itself… but then I don't understand why 'test' gets underlined at all.
You have "test" underlined because your overlay covers it. Try the
variant below instead.
> * I need to override the underline that might be present on "BBB"
> * There's a line continuation indicator after each long line. Maybe with a more clever :align-to spec?
Probably.
(with-current-buffer (get-buffer-create "*test*")
(insert "test\ntest\ntest")
(let ((ov (make-overlay 6 7))
(str (concat (propertize " " 'display '(space :height (1) :align-to right) 'face '(:underline t))
"AAA\n"
"BBB"
(propertize " " 'display '(space :height (1) :align-to right) 'face '(:underline t)))))
(overlay-put ov 'before-string str)
(overlay-put ov 'face '(:underline t)))
(pop-to-buffer (current-buffer)))
next prev parent reply other threads:[~2019-05-08 18:25 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-07 16:40 Line height issues with display-line-number-mode Clément Pit-Claudel
2019-05-07 17:12 ` Noam Postavsky
2019-05-07 18:36 ` Eli Zaretskii
2019-05-07 19:00 ` Eli Zaretskii
2019-05-07 19:09 ` Stefan Monnier
2019-05-07 19:43 ` Eli Zaretskii
2019-05-07 20:30 ` Stefan Monnier
2019-05-08 6:43 ` Eli Zaretskii
2019-05-08 13:39 ` Stefan Monnier
2019-05-08 14:05 ` Eli Zaretskii
2019-05-08 14:13 ` Noam Postavsky
2019-05-08 15:04 ` Stefan Monnier
2019-05-08 18:39 ` Noam Postavsky
2019-05-08 18:54 ` Eli Zaretskii
2019-05-10 6:15 ` Kévin Le Gouguec
2019-05-10 7:58 ` Eli Zaretskii
2019-05-10 13:24 ` Stefan Monnier
2019-05-08 14:17 ` Stefan Monnier
2019-05-08 17:30 ` Eli Zaretskii
2019-05-08 17:46 ` Stefan Monnier
2019-05-08 18:02 ` Eli Zaretskii
2019-05-08 18:39 ` Stefan Monnier
2019-05-08 18:48 ` Eli Zaretskii
2019-05-08 19:03 ` Stefan Monnier
2019-05-07 19:49 ` Ergus
2019-05-08 5:51 ` Eli Zaretskii
2019-05-08 13:40 ` Stefan Monnier
2019-05-08 14:07 ` Eli Zaretskii
2019-05-07 18:31 ` Eli Zaretskii
2019-05-07 21:08 ` Clément Pit-Claudel
2019-05-08 7:01 ` Eli Zaretskii
2019-05-08 12:24 ` Clément Pit-Claudel
2019-05-08 14:00 ` Eli Zaretskii
2019-05-08 18:04 ` Clément Pit-Claudel
2019-05-08 18:25 ` Eli Zaretskii [this message]
2019-05-08 18:45 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83k1f0hkgf.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=cpitclaudel@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).