From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Towards a cleaner build: arc-mode Date: Sat, 18 May 2019 08:57:27 +0300 Message-ID: <83k1eo9uew.fsf@gnu.org> References: <83d0khb888.fsf@gnu.org> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="112558"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat May 18 08:02:53 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hRsQn-000TAU-CK for ged-emacs-devel@m.gmane.org; Sat, 18 May 2019 08:02:53 +0200 Original-Received: from localhost ([127.0.0.1]:58144 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hRsQm-00033O-Co for ged-emacs-devel@m.gmane.org; Sat, 18 May 2019 02:02:52 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:45752) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hRsQO-0002oh-Ir for emacs-devel@gnu.org; Sat, 18 May 2019 02:02:29 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:42067) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hRsLd-0002Ld-6q; Sat, 18 May 2019 01:57:33 -0400 Original-Received: from [176.228.60.248] (port=4185 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hRsLc-0003a3-IG; Sat, 18 May 2019 01:57:32 -0400 In-reply-to: (message from Lars Ingebrigtsen on Sat, 18 May 2019 06:36:25 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:236700 Archived-At: > From: Lars Ingebrigtsen > Cc: emacs-devel@gnu.org > Date: Sat, 18 May 2019 06:36:25 +0200 > > Eli Zaretskii writes: > > > Yes. However, I suspect this juggling is no longer need nowadays. If > > you just use 'insert', does arc-mode break when you invoke the > > commands that end up using these calls? This should be tried also in > > a locale whose codeset is not UTF-8. > > Yes, if I just insert the bytes, things break. In a zip file, I did a > chmod change to 0777 and in the new file, I got: > > -rwxrwxrwx 5 18-May-2019 05:27:06 text.txt > > If I do the same, but replace > > (insert (if (< elt 128) elt (decode-char 'eight-bit elt))) > > with just > > (insert elt) > > I get: > > crws--S-wx 5 18-May-2019 05:27:06 ^@^@text.t Sorry, that's not what I meant. (I guess I've misunderstood what you were asking about, and thus my "juggling" was misinterpreted.) I meant to do this instead: (defun insert-unibyte (&rest args) "Like insert but don't make unibyte string and eight-bit char multibyte." (dolist (elt args) (if (integerp elt) (insert (if (< elt 128) elt (decode-char 'eight-bit elt))) (insert elt)))) IOW, just lose the string-to-multibyte part, as I don't think it's needed nowadays, since 'insert' already does the equivalent of string-to-multibyte when needed. The warning we want to get rid off is about string-to-multibyte, not about decode-char, right?