unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Juri Linkov <juri@linkov.net>
Cc: lekktu@gmail.com, emacs-devel@gnu.org
Subject: Re: Tab bar tabs landed on master
Date: Sun, 06 Oct 2019 20:06:16 +0300	[thread overview]
Message-ID: <83k19h3it3.fsf@gnu.org> (raw)
In-Reply-To: <87a7aex2v9.fsf@mail.linkov.net> (message from Juri Linkov on Sun, 06 Oct 2019 01:07:54 +0300)

> From: Juri Linkov <juri@linkov.net>
> Cc: lekktu@gmail.com,  emacs-devel@gnu.org
> Date: Sun, 06 Oct 2019 01:07:54 +0300
> 
> > Can you explain how tab-bar-handle-mouse is supposed to work on TTY
> > frames with a mouse?  It doesn't work for me on the MS-Windows
> > console: I get "<nil> <mouse-1> is undefined".  Which makes sense to
> > me, as I don't see any code which would generate a TAB_BAR_EVENT event
> > on a TTY, so I thought I need to write code to implement that in the
> > TTY case.  However, the doc string of tab-bar-handle-mouse seems to
> > imply that I'm missing something.
> 
> tab-bar-make-keymap-1 binds '(keymap (mouse-1 . tab-bar-handle-mouse))
> that on TTY frames accepts mouse clicks anywhere on the tab bar,
> and then tab-bar-handle-mouse finds the clicked tab.
> 
> > Did you try the code on TTY frames with some mouse capability, and if
> > so, what was your configuration?
> 
> On TTY frames on GNU/Linux the code works well after enabling
> xterm-mouse-mode.

That means platforms that support TTY mouse on the C level (GPM and
MS-Windows/MS-DOS) will not be able to invoke tab-bar commands with a
mouse, because there's no code that would produce the relevant events
Emacs expects.  xt-mouse bypasses the normal channels of feeding mouse
events to the event queue, so implementation that works with xt-mouse
alone generally doesn't produce the infrastructure required by "real"
mouse support on TTY frames.

> I tried to test it on MS-Windows too, but can't figure out how to
> enable mouse on the MS-Windows console.  I was able to run 'emacs
> -nw' only on winpty.  Could you suggest how mouse could be enabled
> on the MS-Windows console?

It is enabled by default.  Maybe your cmd window has the Quick Edit
mode enabled, in which case mouse events are not reported to console
applications, but instead handled by Windows.  I have now installed
code to disable Quick Edit when Emacs starts, so you shouldn't need to
do that persistently (this option can be controlled in the Properties
of the cmd window).

I also installed support for mouse gestures on the tab bar on
text-mode frames.  It currently only works on MS-Windows, but should
be easy to extend to GPM as well.  Do you have access to a system with
a GPM-capable console, and can compile Emacs with GPM support?  If so,
I will send a patch for you to try (I don't myself have access to such
a system, so I cannot try it myself).

Thanks.



  reply	other threads:[~2019-10-06 17:06 UTC|newest]

Thread overview: 82+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-01 20:17 Tab bar tabs landed on master Juri Linkov
2019-10-01 21:43 ` Juanma Barranquero
2019-10-01 22:28   ` Juri Linkov
2019-10-01 22:35     ` Juanma Barranquero
2019-10-01 23:27     ` Ergus
2019-10-03 22:10       ` Juri Linkov
2019-10-05 21:55       ` Juri Linkov
2019-10-06 17:13         ` Eli Zaretskii
2019-10-06 18:48           ` Juri Linkov
2019-10-06 19:12             ` Eli Zaretskii
2019-10-06 19:23               ` Juri Linkov
2019-10-06 19:38                 ` Eli Zaretskii
2019-10-06 19:53                   ` Juri Linkov
2019-10-07 17:18                     ` Eli Zaretskii
2019-10-07 17:31                       ` Lars Ingebrigtsen
2019-10-07 17:49                       ` Ergus
2019-10-06 21:11                   ` Stefan Monnier
2019-10-06 21:27                     ` Juri Linkov
2019-10-06 22:53                       ` Stefan Monnier
2019-10-06 22:58                       ` add Tab to ELPA other-frame-window Stephen Leake
2019-10-07 16:07                         ` Eli Zaretskii
2019-10-07 20:14                         ` Juri Linkov
2019-10-08  7:48                           ` Eli Zaretskii
2019-10-10 22:46                             ` Juri Linkov
2019-10-11  8:10                               ` Eli Zaretskii
2019-10-19 22:07                                 ` Juri Linkov
2019-10-20  6:24                                   ` Eli Zaretskii
2019-10-20 17:37         ` Tab bar tabs landed on master Juri Linkov
2019-10-23 20:54           ` Juri Linkov
2019-10-26 22:16             ` Juri Linkov
2019-10-27 23:05               ` Juri Linkov
2019-10-23 20:59         ` Juri Linkov
2019-11-01 23:13           ` Ergus
2019-11-02  7:20             ` Eli Zaretskii
2019-11-02 11:46               ` Ergus
2019-10-02  8:55     ` martin rudalics
2019-10-02 16:30       ` Juri Linkov
2019-10-02 15:03   ` Eli Zaretskii
2019-10-02 16:27     ` Juri Linkov
2019-10-02 17:07       ` Eli Zaretskii
2019-10-02 19:55         ` Juri Linkov
2019-10-05 14:33           ` Eli Zaretskii
2019-10-05 22:07             ` Juri Linkov
2019-10-06 17:06               ` Eli Zaretskii [this message]
2019-10-07 19:15                 ` Juri Linkov
2019-10-07 19:23                   ` Eli Zaretskii
2019-10-09 10:51                     ` Eli Zaretskii
2019-10-09 18:43                       ` Juri Linkov
2019-10-09 18:59                         ` Eli Zaretskii
2020-01-11 23:57                           ` Juri Linkov
2020-01-12  3:28                             ` Eli Zaretskii
2020-01-12 23:25                               ` Juri Linkov
2020-01-13 16:49                                 ` Eli Zaretskii
2020-01-13 23:35                                   ` Juri Linkov
2020-04-18 23:56                                     ` Juri Linkov
2020-04-19 14:06                                       ` Eli Zaretskii
2019-11-14 23:37                       ` Juri Linkov
2019-11-15  8:21                         ` Eli Zaretskii
2019-10-03  8:16         ` martin rudalics
2019-10-03  8:15       ` martin rudalics
2019-10-03  3:40 ` Stefan Kangas
2019-10-03  9:02 ` Robert Pluim
2019-10-07 13:15 ` Stefan Kangas
2019-10-07 13:21 ` Stefan Kangas
2019-10-07 15:53   ` Ergus
2019-10-07 20:23     ` Juri Linkov
2019-10-07 20:58       ` Ergus
2019-10-07 21:48       ` Zach Pearson
2019-10-07 22:29         ` Juri Linkov
2019-10-08 14:29           ` Eli Zaretskii
2019-10-09 22:43             ` Juri Linkov
2019-10-10  7:52               ` Eli Zaretskii
2019-10-07 16:40   ` Eli Zaretskii
2019-10-07 20:19   ` Juri Linkov
2019-10-08  7:52     ` Eli Zaretskii
2019-10-20 22:39   ` Juri Linkov
2019-10-20 23:06     ` Ergus
2019-10-21  6:54       ` Eli Zaretskii
2019-10-21  6:43     ` Eli Zaretskii
2019-10-21 21:40       ` Juri Linkov
  -- strict thread matches above, loose matches on Subject: below --
2019-10-03 11:23 Andrii Kolomoiets
2019-10-03 12:19 ` Robert Pluim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83k19h3it3.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=juri@linkov.net \
    --cc=lekktu@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).