From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master 3de31e7: Fix compilation of image.c on MS-Windows Date: Mon, 09 Nov 2020 18:20:05 +0200 Message-ID: <83k0uu4i4q.fsf@gnu.org> References: <20201109153652.21064.52372@vcs0.savannah.gnu.org> <20201109153654.3EADA20A27@vcs0.savannah.gnu.org> <87pn4mjz3m.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3716"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Lars Ingebrigtsen , Alan Third Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Nov 09 17:23:12 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kc9wl-0000r3-8E for ged-emacs-devel@m.gmane-mx.org; Mon, 09 Nov 2020 17:23:11 +0100 Original-Received: from localhost ([::1]:51624 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kc9wj-0003Mj-T0 for ged-emacs-devel@m.gmane-mx.org; Mon, 09 Nov 2020 11:23:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46082) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kc9tf-0008Ed-0F for emacs-devel@gnu.org; Mon, 09 Nov 2020 11:19:59 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:46264) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kc9te-0006z5-Fl; Mon, 09 Nov 2020 11:19:58 -0500 Original-Received: from [176.228.60.248] (port=1998 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kc9td-0000wF-7b; Mon, 09 Nov 2020 11:19:57 -0500 In-Reply-To: <87pn4mjz3m.fsf@gnus.org> (message from Lars Ingebrigtsen on Mon, 09 Nov 2020 17:04:29 +0100) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:258950 Archived-At: > From: Lars Ingebrigtsen > Cc: Eli Zaretskii > Date: Mon, 09 Nov 2020 17:04:29 +0100 > > eliz@gnu.org (Eli Zaretskii) writes: > > > Fix compilation of image.c on MS-Windows > > > > This is a followup to last change in image.c. > > * src/image.c (rsvg_handle_get_intrinsic_dimensions): Define to > > call fn_rsvg_handle_get_intrinsic_dimensions. > > (svg_css_length_to_pixels): Compile only for librsvg >= 2.46.0, as > > RsvgLength type was not defined before. > > This leads to the following warnings on Debian bullseye, apparently: > > image.c: In function ‘svg_css_length_to_pixels’: > image.c:9769:13: warning: this statement may fall through [-Wimplicit-fallthrough=] Surely, not my change led to this: I only made that code be conditionally compiled. Alan, can you take a look, please? Di d you mean for the control flow to fall-though in these places?