From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: master ac6b62b: * lisp/time.el (world-clock-mode): Make
 non-interactive.
Date: Fri, 23 Apr 2021 13:34:03 +0300
Message-ID: <83k0otnvc4.fsf@gnu.org>
References: <83sg3ho7ku.fsf@gnu.org>
 <CADwFkmmdJ673ZGk96OP9Bus8xWmxHewAWEboLSvi-dHUdMbS7w@mail.gmail.com>
Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214";
	logging-data="24374"; mail-complaints-to="usenet@ciao.gmane.io"
Cc: emacs-devel@gnu.org
To: Stefan Kangas <stefan@marxist.se>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Apr 23 12:36:48 2021
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane-mx.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1lZtB1-00066q-Bb
	for ged-emacs-devel@m.gmane-mx.org; Fri, 23 Apr 2021 12:36:47 +0200
Original-Received: from localhost ([::1]:44190 helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1lZtB0-0000Uc-Ck
	for ged-emacs-devel@m.gmane-mx.org; Fri, 23 Apr 2021 06:36:46 -0400
Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53832)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>) id 1lZt8U-0007Bp-RG
 for emacs-devel@gnu.org; Fri, 23 Apr 2021 06:34:10 -0400
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:43366)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@gnu.org>)
 id 1lZt8U-0005P0-GK; Fri, 23 Apr 2021 06:34:10 -0400
Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1589
 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <eliz@gnu.org>)
 id 1lZt8S-000807-Uu; Fri, 23 Apr 2021 06:34:09 -0400
In-Reply-To: <CADwFkmmdJ673ZGk96OP9Bus8xWmxHewAWEboLSvi-dHUdMbS7w@mail.gmail.com>
 (message from Stefan Kangas on Fri, 23 Apr 2021 09:22:29 +0000)
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org
Original-Sender: "Emacs-devel"
 <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Xref: news.gmane.io gmane.emacs.devel:268310
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/268310>

> From: Stefan Kangas <stefan@marxist.se>
> Date: Fri, 23 Apr 2021 09:22:29 +0000
> Cc: emacs-devel@gnu.org
> 
> >>  (define-derived-mode world-clock-mode special-mode "World clock"
> >>    "Major mode for buffer that displays times in various time zones.
> >>  See `world-clock'."
> >> +  :interactive nil
> >>    (setq-local revert-buffer-function #'world-clock-update)
> >>    (setq show-trailing-whitespace nil))
> >
> > Stefan, can you give your rationale for the change?  Why should user
> > be unable to invoke this mode interactively, when they could do so for
> > a long time?
> 
> This mode is only useful in a buffer prepared for its use by
> `world-clock'.  Running it in an arbitrary buffer will silently fail.

Is that true also for turning off the mode?