From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Increase default `line-spacing' to 0.05, 0.10 or 0.15 [proposal] Date: Sat, 08 May 2021 11:06:36 +0300 Message-ID: <83k0o9abub.fsf@gnu.org> References: <83mtt7chrt.fsf@gnu.org> <83zgx5agt2.fsf@gnu.org> <72d55429-37ee-cb16-c939-2b274a936136@grinta.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9862"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Daniele Nicolodi Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat May 08 10:07:11 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lfHzT-0002SB-8O for ged-emacs-devel@m.gmane-mx.org; Sat, 08 May 2021 10:07:11 +0200 Original-Received: from localhost ([::1]:37060 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lfHzR-0007cO-JJ for ged-emacs-devel@m.gmane-mx.org; Sat, 08 May 2021 04:07:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39604) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lfHyw-0006xU-2Q for emacs-devel@gnu.org; Sat, 08 May 2021 04:06:38 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:54454) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lfHyu-0000qf-Vp; Sat, 08 May 2021 04:06:36 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4726 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lfHyu-0002ib-Du; Sat, 08 May 2021 04:06:36 -0400 In-Reply-To: <72d55429-37ee-cb16-c939-2b274a936136@grinta.net> (message from Daniele Nicolodi on Sat, 8 May 2021 09:51:12 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:269028 Archived-At: > From: Daniele Nicolodi > Date: Sat, 8 May 2021 09:51:12 +0200 > > On 08/05/2021 08:19, Eli Zaretskii wrote: > > On the implementation side, I'm not sure I understand how do you > > intend to implement these values: 110% of what? Line spacing is > > eventually a pixel value; you can, of course, compute it in percents > > of the font size, but then the nominal spacing will not have the 100% > > or 1.0 value, right? So how do you intend to convert the value in the > > menu into the actual line-spacing value? > > The documentation for the line-spacing variable says: > > Documentation: > Additional space to put between lines when displaying a buffer. The > space is measured in pixels, and put below lines on graphic displays, > see ‘display-graphic-p’. > If value is a floating point number, it specifies the spacing relative > to the default frame line height. A value of nil means add no extra space. > > I think the values in the menu would simply be divided by 100. So you are saying that 100% would mean line-spacing equal to the default frame line height? That would mean the line height that is twice as high as the default, so (a) 100% is hardly a good description, and (b) how do you provide an option to get back to the default value? IOW, the default is that we add zero spacing, and that makes percent notation not trivially convertible. As the doc string says, this is _additional_ space.