From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Moving kbd to subr.el Date: Thu, 14 Oct 2021 14:56:53 +0300 Message-ID: <83k0iflsze.fsf@gnu.org> References: <20211004081724.6281.11798@vcs0.savannah.gnu.org> <20211004081727.4F24921048@vcs0.savannah.gnu.org> <871r4qcs8s.fsf@gnus.org> <87o87ubcnl.fsf@gnus.org> <87h7dm9en7.fsf@gnus.org> <87czoa9e7p.fsf@gnus.org> <878ryxakv9.fsf@gnus.org> <834k9km5no.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17571"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, emacs-devel@gnu.org To: Stefan Kangas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Oct 14 13:58:13 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mazNE-0004K6-Tp for ged-emacs-devel@m.gmane-mx.org; Thu, 14 Oct 2021 13:58:12 +0200 Original-Received: from localhost ([::1]:55572 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mazND-0002TF-RI for ged-emacs-devel@m.gmane-mx.org; Thu, 14 Oct 2021 07:58:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40360) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mazM0-0000PG-3T for emacs-devel@gnu.org; Thu, 14 Oct 2021 07:56:56 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:43390) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mazLz-0005qJ-QU; Thu, 14 Oct 2021 07:56:55 -0400 Original-Received: from [87.69.77.57] (port=3293 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mazLz-0004Kh-Cv; Thu, 14 Oct 2021 07:56:55 -0400 In-Reply-To: (message from Stefan Kangas on Thu, 14 Oct 2021 04:50:31 -0700) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:276996 Archived-At: > From: Stefan Kangas > Date: Thu, 14 Oct 2021 04:50:31 -0700 > Cc: larsi@gnus.org, emacs-devel@gnu.org > > > No NEWS entry? > > I consider this as an internal change that should have no user impact. > So I'm not sure this needs a NEWS-entry; if you think it does, please > clarify what you think we should put in it. Using kbd no longer needs to require edmacro, so it isn't entirely internal. > > No sure I understand: the rationale for introducing internal--kbd > > instead of using kbd directly is because we need an extra optional > > argument? if so, why not add that argument to kbd itself? > > We could, but I feel like that's an implementation detail: an artifact > of the fact that kbd and edmacro-parse-keys share code. I don't think > the parameter will be useful to users of kbd, and therefore risks > confusing instead. So adding a new internal function seemed like a > small price to pay. > > I have added this comment to the beginning of the function to make the > reasoning clear: > > ;; NB. This function exists mainly to avoid adding a "need-vector" > ;; argument to the user-facing function `kbd'. That sounds less clean than I'd like it to be, FWIW. Having a trivial wrapper in our own code just to avoid an optional argument? Lars, WDYT?