unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Gregory Heytings <gregory@heytings.org>
Cc: larsi@gnus.org, rpluim@gmail.com, emacs-devel@gnu.org
Subject: Re: Crash with --enable-checking and some glyphs
Date: Sun, 28 Nov 2021 09:21:37 +0200	[thread overview]
Message-ID: <83k0gsycce.fsf@gnu.org> (raw)
In-Reply-To: <227d35a5bc18f4dc6e25@heytings.org> (message from Gregory Heytings on Sat, 27 Nov 2021 22:01:05 +0000)

> Date: Sat, 27 Nov 2021 22:01:05 +0000
> From: Gregory Heytings <gregory@heytings.org>
> cc: Eli Zaretskii <eliz@gnu.org>, rpluim@gmail.com, emacs-devel@gnu.org
> 
> I very much doubt that this is the root cause of this bug.

What do you mean by "this"?

The fix that I installed didn't pretend to fix any root causes,
because those are not known.  I just verified that the code in that
part does its job and works according to what the font metrics
returned by the font backend feeds it.  Since the fonts are identical,
the root cause could be in the font backend (which is not our code) or
maybe elsewhere.  You are welcome to investigate further, but my
suggestion is to start from xftfont.c and its ilk, tracing the
information it returns for the font in question.

The problem is also extremely rare, because otherwise everyone who
builds Emacs with --enable-checking would see frequent crashes long
ago.

In any case, the installed fix just does what other branches of that
function already did for glyphs that are not simple character glyphs,
that's all.  It "corrects" the ascent and descent values after they
have been already used for the glyph metrics on our display, so its
effect on the display should be minimal at best, and usually nil.  But
if you have evidence to the contrary, by all means present it, and
let's see what we should and can do about that.



  reply	other threads:[~2021-11-28  7:21 UTC|newest]

Thread overview: 130+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-24 13:53 Proportional fonts in the mode line (one month test) Lars Ingebrigtsen
2021-11-24 13:54 ` Lars Ingebrigtsen
2021-11-24 14:12   ` Lars Ingebrigtsen
2021-11-24 14:16     ` Lars Ingebrigtsen
2021-11-24 14:42       ` Eli Zaretskii
2021-11-24 14:46         ` Lars Ingebrigtsen
2021-11-24 14:54           ` Eli Zaretskii
2021-11-24 15:00             ` Lars Ingebrigtsen
2021-11-24 15:12               ` Lars Ingebrigtsen
2021-11-24 17:01                 ` Crash with --enable-checking and some glyphs Lars Ingebrigtsen
2021-11-24 17:55                   ` Robert Pluim
2021-11-25 12:51                     ` Lars Ingebrigtsen
2021-11-25 13:09                       ` Andreas Schwab
2021-11-25 13:39                         ` Lars Ingebrigtsen
2021-11-25 14:36                       ` Robert Pluim
2021-11-25 14:39                         ` Lars Ingebrigtsen
2021-11-25 14:51                           ` Lars Ingebrigtsen
2021-11-25 15:02                             ` Gregory Heytings
2021-11-25 15:11                               ` Lars Ingebrigtsen
2021-11-25 15:36                                 ` Gregory Heytings
2021-11-25 16:03                                   ` Lars Ingebrigtsen
2021-11-25 16:18                                     ` Gregory Heytings
2021-11-26 12:14                                       ` Lars Ingebrigtsen
2021-11-25 15:14                             ` Eli Zaretskii
2021-11-26 12:18                               ` Lars Ingebrigtsen
2021-11-26 12:50                                 ` Eli Zaretskii
2021-11-26 14:30                                   ` Lars Ingebrigtsen
2021-11-26 15:00                                     ` Eli Zaretskii
2021-11-26 15:04                                       ` Lars Ingebrigtsen
2021-11-26 16:27                                         ` Eli Zaretskii
2021-11-27  8:37                                           ` Eli Zaretskii
2021-11-27 14:04                                           ` Lars Ingebrigtsen
2021-11-27 15:12                                             ` Eli Zaretskii
2021-11-27 15:25                                               ` Lars Ingebrigtsen
2021-11-28  0:41                                                 ` Po Lu
2021-11-27 21:28                                               ` Gregory Heytings
2021-11-27 21:31                                                 ` Lars Ingebrigtsen
2021-11-27 22:01                                                   ` Gregory Heytings
2021-11-28  7:21                                                     ` Eli Zaretskii [this message]
2021-11-29 13:55                                                       ` Gregory Heytings
2021-11-29 14:01                                                         ` Lars Ingebrigtsen
2021-11-25 15:23                   ` Óscar Fuentes
2021-11-25 21:29                   ` Gregor Zattler
2021-11-26 13:01                   ` Po Lu
2021-11-27  0:18                     ` Po Lu
2021-11-24 18:49                 ` Proportional fonts in the mode line (one month test) Uwe Brauer
2021-11-24 19:12                   ` Lars Ingebrigtsen
2021-11-24 19:44                     ` Eli Zaretskii
2021-11-25  0:52                       ` Po Lu
2021-11-25 12:42                         ` Lars Ingebrigtsen
2021-11-25 12:41                       ` Lars Ingebrigtsen
2021-11-25  1:01               ` Po Lu
2021-11-24 14:40 ` Eli Zaretskii
2021-11-24 14:44   ` Manuel Uberti
2021-11-24 16:25 ` Yuri D'Elia
2021-11-24 16:38 ` Óscar Fuentes
2021-11-24 16:50   ` Yuan Fu
2021-11-24 17:09     ` Óscar Fuentes
2021-11-24 17:18       ` Lars Ingebrigtsen
2021-11-24 17:26         ` Yuan Fu
2021-11-24 17:18       ` Yuan Fu
2021-11-24 16:49 ` Yuan Fu
2021-11-24 16:55   ` Lars Ingebrigtsen
2021-11-24 17:32     ` Yuan Fu
2021-11-24 16:51 ` Dmitry Gutov
2021-11-24 16:58   ` Yuan Fu
2021-11-24 17:22   ` Eli Zaretskii
2021-11-24 17:26     ` Lars Ingebrigtsen
2021-11-24 17:54       ` Eli Zaretskii
2021-11-24 17:58         ` Lars Ingebrigtsen
2021-11-24 18:42           ` Eli Zaretskii
2021-11-25 12:37             ` Lars Ingebrigtsen
2021-11-25 13:15               ` Eli Zaretskii
2021-11-24 17:55       ` Lars Ingebrigtsen
2021-11-24 18:57         ` Manuel Uberti
2021-11-25 12:39           ` Lars Ingebrigtsen
2021-11-25 14:04             ` Manuel Uberti
2021-11-25 22:20               ` Tim Cross
2021-11-24 19:20     ` Dmitry Gutov
2021-11-24 16:51 ` Filipp Gunbin
2021-11-24 17:36 ` [External] : " Drew Adams
2021-11-24 17:39   ` Lars Ingebrigtsen
2021-11-25  0:18 ` Po Lu
2021-11-25  0:39   ` Po Lu
2021-11-25  1:48     ` Jim Porter
2021-11-25 13:29       ` Lars Ingebrigtsen
2021-11-25 14:03         ` Eli Zaretskii
2021-11-25 19:41         ` Jim Porter
2021-11-25 23:04           ` Kévin Le Gouguec
2021-11-26  2:44             ` Jim Porter
2021-11-26 17:07               ` Yuan Fu
2021-11-27  0:18               ` Po Lu
2021-11-26  4:53             ` Yuri Khan
2021-11-26  5:04             ` Po Lu
2021-11-26 12:35             ` Lars Ingebrigtsen
2021-11-27 21:50               ` Jim Porter
2021-11-25  7:45     ` Eli Zaretskii
2021-11-25  7:59       ` Po Lu
2021-11-25 13:28   ` Lars Ingebrigtsen
2021-11-25 13:34     ` Eli Zaretskii
2021-11-25 14:05       ` Lars Ingebrigtsen
2021-11-26 13:19         ` Lars Ingebrigtsen
2021-11-25  6:26 ` Protesilaos Stavrou
2021-11-25  8:03   ` Eli Zaretskii
2021-11-25  9:00     ` Gregory Heytings
2021-11-25 13:33   ` Lars Ingebrigtsen
2021-11-25  9:06 ` Simen Heggestøyl
2021-11-25 13:33   ` Lars Ingebrigtsen
2021-11-25 14:17     ` Lars Ingebrigtsen
2021-11-29 14:52 ` Michael Welsh Duggan
2021-11-29 15:03   ` Eli Zaretskii
2021-11-29 15:11     ` Lars Ingebrigtsen
2021-12-01  5:59 ` Jim Porter
2021-12-01  8:26   ` Davide Masserut
2021-12-01 12:30 ` Eric S Fraga
2021-12-01 13:41   ` Lars Ingebrigtsen
2021-12-01 13:46     ` Eric S Fraga
2021-12-01 13:54       ` Lars Ingebrigtsen
2021-12-01 14:19         ` Eric S Fraga
2021-12-01 14:40           ` Eli Zaretskii
2021-12-01 14:45             ` Eric S Fraga
2021-12-03  3:09               ` João Pedro de Amorim Paula
2021-12-03 11:45                 ` Eric S Fraga
2021-12-04  5:41                 ` Richard Stallman
2021-12-04  6:24                   ` Po Lu
2021-12-05 13:04                 ` Eric S Fraga
2021-12-05 20:46                   ` James Cloos
2021-12-05 22:06                   ` João Pedro de Amorim Paula
2021-12-01 15:00       ` Yuri Khan
2021-12-01 15:08         ` Eric S Fraga

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83k0gsycce.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=gregory@heytings.org \
    --cc=larsi@gnus.org \
    --cc=rpluim@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).