From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Compiler warnings in dispnew.c Date: Sun, 28 Nov 2021 17:29:26 +0200 Message-ID: <83k0gswb6x.fsf@gnu.org> References: <87fsrg7gdt.fsf.ref@yahoo.com> <87fsrg7gdt.fsf@yahoo.com> <83tufwwo7z.fsf@gnu.org> <87bl247dbn.fsf@yahoo.com> <87wnksfsiy.fsf@linux-m68k.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28926"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Andreas Schwab , emacs-devel@gnu.org To: luangruo@yahoo.com Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Nov 28 16:29:57 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mrM7p-0007Ha-Ah for ged-emacs-devel@m.gmane-mx.org; Sun, 28 Nov 2021 16:29:57 +0100 Original-Received: from localhost ([::1]:56386 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mrM7n-0004cc-M0 for ged-emacs-devel@m.gmane-mx.org; Sun, 28 Nov 2021 10:29:55 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:35680) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mrM7C-0003u6-3z for emacs-devel@gnu.org; Sun, 28 Nov 2021 10:29:18 -0500 Original-Received: from [2001:470:142:3::e] (port=36128 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mrM7B-0007ri-6d; Sun, 28 Nov 2021 10:29:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=0Y/LWiena9jbJc8SrwYXo9CqQ5uKY7KWJnZOIj8TiF0=; b=ZVcp5DzurhNe AqMSj6XHNzpju1EHt7IalkRuU/H7d0WqLj07GBH2VH9TjIc/yfoucbcDyDW84u1FqU5zQR9mNye1l hG5J4jCHgVuQU4G8rIcftsB/4FpR2P/xSCpJ+UIF1o2vHnczICoe8fouFeNWDW1BC6Bh6OPOIQd/M WKJpSGSmOW0NtbwMdT93Da3zjXnJBzC0pxxQ2q9VrlZ90QBXz1Jn6e3+YTpmFgzSBH2Qq6XijfsBr YUdgs2YK1xdV9/0qwXEQ4/haJRH1wL9sil+/yekgB3DwlhVQg7LADW7TMY/rAjLignQ0RF9vknyEx 2PcxEmpQKs/ftts9U3HHGg==; Original-Received: from [87.69.77.57] (port=2664 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mrM7A-00022r-TE; Sun, 28 Nov 2021 10:29:17 -0500 In-Reply-To: <87wnksfsiy.fsf@linux-m68k.org> (message from Andreas Schwab on Sun, 28 Nov 2021 12:07:01 +0100) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:280420 Archived-At: > From: Andreas Schwab > Date: Sun, 28 Nov 2021 12:07:01 +0100 > Cc: Eli Zaretskii , emacs-devel@gnu.org > > Does that work? > > diff --git a/src/dispnew.c b/src/dispnew.c > index f3f110a8f2..a976bf94c5 100644 > --- a/src/dispnew.c > +++ b/src/dispnew.c > @@ -1034,7 +1034,7 @@ copy_row_except_pointers (struct glyph_row *to, struct glyph_row *from) > { > enum { off = offsetof (struct glyph_row, x) }; > > - memcpy (&to->x, &from->x, sizeof *to - off); > + memcpy ((char *) to + off, (char *) from + off, sizeof *to - off); > } Po Lu, please try this and tell if the warning goes away. Thanks.