From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master 3d38d1d: Add sqlite3 support to Emacs Date: Sat, 11 Dec 2021 10:50:29 +0200 Message-ID: <83k0gbr0dm.fsf@gnu.org> References: <20211211035614.15517.53830@vcs0.savannah.gnu.org> <20211211035616.984DD20A0A@vcs0.savannah.gnu.org> <87ee6j4ty4.fsf@yahoo.com> <8735mz4o70.fsf@yahoo.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1015"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, stefankangas@gmail.com, rms@gnu.org, emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Dec 11 09:51:41 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mvy6W-000Ad2-Lp for ged-emacs-devel@m.gmane-mx.org; Sat, 11 Dec 2021 09:51:40 +0100 Original-Received: from localhost ([::1]:55938 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mvy6U-0004DE-F1 for ged-emacs-devel@m.gmane-mx.org; Sat, 11 Dec 2021 03:51:38 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:43432) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mvy5f-0003RB-C7 for emacs-devel@gnu.org; Sat, 11 Dec 2021 03:50:48 -0500 Original-Received: from [2001:470:142:3::e] (port=49902 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mvy5e-0004hQ-Tv; Sat, 11 Dec 2021 03:50:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=9nAQfPVCDcGuRXwILFdygzCCj3bdnsTxJPwfUJFHcDg=; b=U/L1TBi4EfUn LFCwQwZi4i3u4DorzJxw0wHpzwmpws44KC+BntjlmAKasPFu+2lDHB8jJ3gNQTLCHNQCKoKDKpQCk FpG6jEbhS/s8VoWPWe3LnNn08UvEH0Yb8aSGrzRsIs1MYSU13aoxg5u4XdhLf2rvFC09vL+jErto+ 9VHbuefTdUhYJceiA2IAfdwtufVARTNI0YcgkyLMh5gtyQ5nRyaE+lF/jnSRYasX164QQ4Vzams+1 D9RIG9fRmjRuKU7t6uDIe+RCIbkpp+03Sx3blw7su6Nes9AfW1u3MTWiUQSI1eAo2cae1t8cbvmdL JQfwNAHqs58mNxasoSkWBQ==; Original-Received: from [87.69.77.57] (port=4317 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mvy5a-0001li-17; Sat, 11 Dec 2021 03:50:42 -0500 In-Reply-To: <8735mz4o70.fsf@yahoo.com> (message from Po Lu on Sat, 11 Dec 2021 15:04:35 +0800) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:281662 Archived-At: > From: Po Lu > Cc: Lars Ingebrigtsen , emacs-devel@gnu.org, rms@gnu.org > Date: Sat, 11 Dec 2021 15:04:35 +0800 > > Po Lu writes: > > > BTW, this doesn't compile on macOS. It complains that > > `sqlite3_load_extension' is missing. > > On a different note, SQLite3 extensions are linked dynamically, and they > could be proprietary software. AFAIU, the SQLite3 developers even > provide a few proprietary extensions themselves, including one for > database encryption. > > So I think we should check that the .so file passed to > `sqlite-load-extension' as the `module' argument contains a GPL > compatibility symbol before allowing SQLite to load it, similar to what > we do with Emacs modules. Would you like to prepare a patch to that effect, please?