From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Tree-sitter integration on feature/tree-sitter Date: Sun, 08 May 2022 09:58:14 +0300 Message-ID: <83k0awwlx5.fsf@gnu.org> References: <93b1d7c7-65fa-4c14-adad-b0e224bbf01c@email.android.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28468"; mail-complaints-to="usenet@ciao.gmane.io" Cc: casouri@gmail.com, emacs-devel@gnu.org To: Theodor Thornhill Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun May 08 09:01:09 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nnaui-0007Es-U0 for ged-emacs-devel@m.gmane-mx.org; Sun, 08 May 2022 09:01:09 +0200 Original-Received: from localhost ([::1]:43562 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nnauh-0006Da-O3 for ged-emacs-devel@m.gmane-mx.org; Sun, 08 May 2022 03:01:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50752) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nnas5-0005NZ-DJ for emacs-devel@gnu.org; Sun, 08 May 2022 02:58:26 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:50784) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nnas4-0004Av-HZ; Sun, 08 May 2022 02:58:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=VjUsBujM1MnTZGZG/MU5FIMCzhLVHWmVxT+rB71ovvI=; b=PR7ebzIPNhGr AR4NwwmMNW8E7ZQUDZtDcrzvNnL+flPGNzCf82gPNzR7r6lceYaPddPhQD6QCRVZXtd/ngYw4DJjZ Hh3te1z8AzW0a44KGL7La4skmwTlsBITm0XUSiXfuDFwHdvuQMlocjhOiOqxQnOYz/YKR5MFsWDPa yD0vmfTjF7mODHhs9oD2ZqVGeCd/wbyb+a3JfzMsVIoPtouIcym42yFE2OQO0D+LPUUClEGZiKjo2 DgBX9lCQPhk8iz4bvfPWH0wHflBeXvT/yc+gdeDJJG+YliAVvxArBKLsonT18Wd1XIcPHTLmiBZK6 zxGiF3yOxML2yaHrlIQVkg==; Original-Received: from [87.69.77.57] (port=1779 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nnas3-0001tZ-60; Sun, 08 May 2022 02:58:23 -0400 In-Reply-To: <93b1d7c7-65fa-4c14-adad-b0e224bbf01c@email.android.com> (message from Theodor Thornhill on Sun, 08 May 2022 08:49:00 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:289447 Archived-At: > Date: Sun, 08 May 2022 08:49:00 +0200 > From: Theodor Thornhill > Cc: casouri@gmail.com, emacs-devel@gnu.org > > My suggestion would be to modify the Emacs major modes, not to > introduce special stand-alone modes. Making the changes directly in > the existing modes is a faster way towards tree-sitter integration. > > Sure! If I write a patch for js-mode today, will you be able to apply it to the feature branch? Yes, why not? > I'll just put it behind a "js-mode-use-treesit-p" defcustom or something like that? Something like that, yes.