unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* [NonGNU] New packages: avy-menu, flyspell-correct and friends
@ 2022-05-16  3:51 Jai Flack
  2022-05-16 17:30 ` Philip Kaludercic
  0 siblings, 1 reply; 12+ messages in thread
From: Jai Flack @ 2022-05-16  3:51 UTC (permalink / raw)
  To: emacs-devel

[-- Attachment #1: Type: text/plain, Size: 373 bytes --]

Hello everyone.

I would like to submit the following packages [1,2] for submission to
NonGNU ELPA (patches attached).

 - avy-menu
 
 - flyspell-correct
 - flyspell-correct-avy-menu
 - flyspell-correct-helm
 - flyspell-correct-ido
 - flyspell-correct-ivy
 - flyspell-correct-popup

[1] https://github.com/mrkkrp/avy-menu
[2] https://github.com/d12frosted/flyspell-correct

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-elpa-packages-avy-menu-New-package.patch --]
[-- Type: text/x-diff, Size: 752 bytes --]

From de3ab4d80895b09b47172140d06cfe02d6b061e8 Mon Sep 17 00:00:00 2001
From: Jai Flack <jflack@disroot.org>
Date: Mon, 16 May 2022 13:46:39 +1000
Subject: [PATCH] * elpa-packages (avy-menu): New package

---
 elpa-packages | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/elpa-packages b/elpa-packages
index 734584008d..7c1b7128d6 100644
--- a/elpa-packages
+++ b/elpa-packages
@@ -45,6 +45,9 @@
  ("autothemer"          :url "https://github.com/jasonm23/autothemer.git"
   :readme "readme.md")
 
+ ("avy-menu"		:url "https://github.com/mrkkrp/avy-menu"
+  :ignored-files (".github" "default.nix"))
+
  ("better-jumper"       :url "https://github.com/gilbertw1/better-jumper.git"
   :readme "Readme.md"
   :ignored-files ("LICENSE"))
-- 
2.30.2


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #3: 0001-elpa-packages-flyspell-correct-New-package.patch --]
[-- Type: text/x-diff, Size: 3295 bytes --]

From 466ab8a0a1e2694b34e74109f7460802b1212a85 Mon Sep 17 00:00:00 2001
From: Jai Flack <jflack@disroot.org>
Date: Mon, 16 May 2022 13:09:02 +1000
Subject: [PATCH] * elpa-packages (flyspell-correct): New package

* elpa-packages (flyspell-correct-avy-menu): New package
* elpa-packages (flyspell-correct-helm): New package
* elpa-packages (flyspell-correct-ido): New package
* elpa-packages (flyspell-correct-ivy): New package
* elpa-packages (flyspell-correct-popup): New package
---
 elpa-packages | 42 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 42 insertions(+)

diff --git a/elpa-packages b/elpa-packages
index 7c1b7128d6..3fa6a7c994 100644
--- a/elpa-packages
+++ b/elpa-packages
@@ -163,6 +163,48 @@
  ("flymake-kondor"	:url "https://github.com/turbo-cafe/flymake-kondor"
   :ignored-files ("COPYING.txt"))
 
+ ("flyspell-correct"	:url "https://github.com/d12frosted/flyspell-correct"
+  :news "CHANGELOG.org"
+  :ignored-files (".github" "images" "test" "Cask" "LICENSE.md" "Makefile"
+                  "flyspell-correct-avy-menu.el" "flyspell-correct-helm.el"
+                  "flyspell-correct-ido.el" "flyspell-correct-ivy.el"
+                  "flyspell-correct-popup.el" "makem.sh"))
+
+ ("flyspell-correct-avy-menu"	:url "https://github.com/d12frosted/flyspell-correct"
+  :news "CHANGELOG.org"
+  :ignored-files (".github" "images" "test" "Cask" "LICENSE.md" "Makefile"
+                  "flyspell-correct-helm.el" "flyspell-correct-ido.el"
+                  "flyspell-correct-ivy.el" "flyspell-correct-popup.el"
+                  "flyspell-correct.el" "makem.sh"))
+
+ ("flyspell-correct-helm"	:url "https://github.com/d12frosted/flyspell-correct"
+  :news "CHANGELOG.org"
+  :ignored-files (".github" "images" "test" "Cask" "LICENSE.md" "Makefile"
+                  "flyspell-correct-avy-menu.el" "flyspell-correct-ido.el"
+                  "flyspell-correct-ivy.el" "flyspell-correct-popup.el"
+                  "flyspell-correct.el" "makem.sh"))
+
+ ("flyspell-correct-ido"	:url "https://github.com/d12frosted/flyspell-correct"
+  :news "CHANGELOG.org"
+  :ignored-files (".github" "images" "test" "Cask" "LICENSE.md" "Makefile"
+                  "flyspell-correct-avy-menu.el" "flyspell-correct-helm.el"
+                  "flyspell-correct-ivy.el" "flyspell-correct-popup.el"
+                  "flyspell-correct.el" "makem.sh"))
+
+ ("flyspell-correct-ivy"	:url "https://github.com/d12frosted/flyspell-correct"
+  :news "CHANGELOG.org"
+  :ignored-files (".github" "images" "test" "Cask" "LICENSE.md" "Makefile"
+                  "flyspell-correct-avy-menu.el" "flyspell-correct-helm.el"
+                  "flyspell-correct-ido.el" "flyspell-correct-popup.el"
+                  "flyspell-correct.el" "makem.sh"))
+
+ ("flyspell-correct-popup"	:url "https://github.com/d12frosted/flyspell-correct"
+  :news "CHANGELOG.org"
+  :ignored-files (".github" "images" "test" "Cask" "LICENSE.md" "Makefile"
+                  "flyspell-correct-avy-menu.el" "flyspell-correct-helm.el"
+                  "flyspell-correct-ido.el" "flyspell-correct-ivy.el"
+                  "flyspell-correct.el" "makem.sh"))
+
  ("forth-mode"          :url "https://github.com/larsbrinkhoff/forth-mode"
   :ignored-files ("test" "Makefile" "compile.el"))
 
-- 
2.30.2


[-- Attachment #4: Type: text/plain, Size: 17 bytes --]


-- 
Thanks,
Jai

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [NonGNU] New packages: avy-menu, flyspell-correct and friends
  2022-05-16  3:51 [NonGNU] New packages: avy-menu, flyspell-correct and friends Jai Flack
@ 2022-05-16 17:30 ` Philip Kaludercic
  2022-05-17  8:59   ` Jai Flack
  0 siblings, 1 reply; 12+ messages in thread
From: Philip Kaludercic @ 2022-05-16 17:30 UTC (permalink / raw)
  To: Jai Flack; +Cc: emacs-devel

Jai Flack <jflack@posteo.net> writes:

> Hello everyone.
>
> I would like to submit the following packages [1,2] for submission to
> NonGNU ELPA (patches attached).
>
>  - avy-menu
>  
>  - flyspell-correct
>  - flyspell-correct-avy-menu
>  - flyspell-correct-helm
>  - flyspell-correct-ido
>  - flyspell-correct-ivy
>  - flyspell-correct-popup

Could you perhaps briefly explain what these packages do?  Why the need
for special helm, ido, ivy packages instead of using completing-read?

> [1] https://github.com/mrkkrp/avy-menu
> [2] https://github.com/d12frosted/flyspell-correct
>
> From de3ab4d80895b09b47172140d06cfe02d6b061e8 Mon Sep 17 00:00:00 2001
> From: Jai Flack <jflack@disroot.org>
> Date: Mon, 16 May 2022 13:46:39 +1000
> Subject: [PATCH] * elpa-packages (avy-menu): New package
>
> ---
>  elpa-packages | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/elpa-packages b/elpa-packages
> index 734584008d..7c1b7128d6 100644
> --- a/elpa-packages
> +++ b/elpa-packages
> @@ -45,6 +45,9 @@
>   ("autothemer"          :url "https://github.com/jasonm23/autothemer.git"
>    :readme "readme.md")
>  
> + ("avy-menu"		:url "https://github.com/mrkkrp/avy-menu"
> +  :ignored-files (".github" "default.nix"))
> +
>   ("better-jumper"       :url "https://github.com/gilbertw1/better-jumper.git"
>    :readme "Readme.md"
>    :ignored-files ("LICENSE"))
> -- 
> 2.30.2
>
>
> From 466ab8a0a1e2694b34e74109f7460802b1212a85 Mon Sep 17 00:00:00 2001
> From: Jai Flack <jflack@disroot.org>
> Date: Mon, 16 May 2022 13:09:02 +1000
> Subject: [PATCH] * elpa-packages (flyspell-correct): New package
>
> * elpa-packages (flyspell-correct-avy-menu): New package
> * elpa-packages (flyspell-correct-helm): New package
> * elpa-packages (flyspell-correct-ido): New package
> * elpa-packages (flyspell-correct-ivy): New package
> * elpa-packages (flyspell-correct-popup): New package
> ---
>  elpa-packages | 42 ++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 42 insertions(+)
>
> diff --git a/elpa-packages b/elpa-packages
> index 7c1b7128d6..3fa6a7c994 100644
> --- a/elpa-packages
> +++ b/elpa-packages
> @@ -163,6 +163,48 @@
>   ("flymake-kondor"	:url "https://github.com/turbo-cafe/flymake-kondor"
>    :ignored-files ("COPYING.txt"))
>  
> + ("flyspell-correct"	:url "https://github.com/d12frosted/flyspell-correct"
> +  :news "CHANGELOG.org"
> +  :ignored-files (".github" "images" "test" "Cask" "LICENSE.md" "Makefile"
> +                  "flyspell-correct-avy-menu.el" "flyspell-correct-helm.el"
> +                  "flyspell-correct-ido.el" "flyspell-correct-ivy.el"
> +                  "flyspell-correct-popup.el" "makem.sh"))

These specifications could be simplified if you were to use separate
branches for each package.

> + ("flyspell-correct-avy-menu"	:url "https://github.com/d12frosted/flyspell-correct"
> +  :news "CHANGELOG.org"
> +  :ignored-files (".github" "images" "test" "Cask" "LICENSE.md" "Makefile"
> +                  "flyspell-correct-helm.el" "flyspell-correct-ido.el"
> +                  "flyspell-correct-ivy.el" "flyspell-correct-popup.el"
> +                  "flyspell-correct.el" "makem.sh"))
> +
> + ("flyspell-correct-helm"	:url "https://github.com/d12frosted/flyspell-correct"
> +  :news "CHANGELOG.org"
> +  :ignored-files (".github" "images" "test" "Cask" "LICENSE.md" "Makefile"
> +                  "flyspell-correct-avy-menu.el" "flyspell-correct-ido.el"
> +                  "flyspell-correct-ivy.el" "flyspell-correct-popup.el"
> +                  "flyspell-correct.el" "makem.sh"))
> +
> + ("flyspell-correct-ido"	:url "https://github.com/d12frosted/flyspell-correct"
> +  :news "CHANGELOG.org"
> +  :ignored-files (".github" "images" "test" "Cask" "LICENSE.md" "Makefile"
> +                  "flyspell-correct-avy-menu.el" "flyspell-correct-helm.el"
> +                  "flyspell-correct-ivy.el" "flyspell-correct-popup.el"
> +                  "flyspell-correct.el" "makem.sh"))
> +
> + ("flyspell-correct-ivy"	:url "https://github.com/d12frosted/flyspell-correct"
> +  :news "CHANGELOG.org"
> +  :ignored-files (".github" "images" "test" "Cask" "LICENSE.md" "Makefile"
> +                  "flyspell-correct-avy-menu.el" "flyspell-correct-helm.el"
> +                  "flyspell-correct-ido.el" "flyspell-correct-popup.el"
> +                  "flyspell-correct.el" "makem.sh"))
> +
> + ("flyspell-correct-popup"	:url "https://github.com/d12frosted/flyspell-correct"
> +  :news "CHANGELOG.org"
> +  :ignored-files (".github" "images" "test" "Cask" "LICENSE.md" "Makefile"
> +                  "flyspell-correct-avy-menu.el" "flyspell-correct-helm.el"
> +                  "flyspell-correct-ido.el" "flyspell-correct-ivy.el"
> +                  "flyspell-correct.el" "makem.sh"))
> +
>   ("forth-mode"          :url "https://github.com/larsbrinkhoff/forth-mode"
>    :ignored-files ("test" "Makefile" "compile.el"))
>  
> -- 
> 2.30.2



^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [NonGNU] New packages: avy-menu, flyspell-correct and friends
  2022-05-16 17:30 ` Philip Kaludercic
@ 2022-05-17  8:59   ` Jai Flack
  2022-05-17 18:32     ` Stefan Monnier
  0 siblings, 1 reply; 12+ messages in thread
From: Jai Flack @ 2022-05-17  8:59 UTC (permalink / raw)
  To: Philip Kaludercic; +Cc: emacs-devel

Philip Kaludercic <philipk@posteo.net> writes:

> Jai Flack <jflack@posteo.net> writes:
>
>> Hello everyone.
>>
>> I would like to submit the following packages [1,2] for submission to
>> NonGNU ELPA (patches attached).
>>
>>  - avy-menu
>>  
>>  - flyspell-correct
>>  - flyspell-correct-avy-menu
>>  - flyspell-correct-helm
>>  - flyspell-correct-ido
>>  - flyspell-correct-ivy
>>  - flyspell-correct-popup
>
> Could you perhaps briefly explain what these packages do?  Why the need
> for special helm, ido, ivy packages instead of using completing-read?

That would be helpful wouldn't it ;).

 - avy-menu

   I'm requesting avy-menu for completeness because it is a dependency
   flyspell-correct-avy-menu. It will offer selection options in a
   temporary window at the bottom of the screen which are selectable
   using avy.

 - flyspell-correct

   A wrapper around flyspell to make writing interfaces such as the ones
   below easier. It defines an interface for correcting spelling errors
   with flyspell, allowing the interface (method of selecting
   replacements) to be customised by setting
   `flyspell-correct-interface'.

   It defines four functions for the user
   - flyspell-correct-wrapper :: offers corrections for the first
     incorrect word before point, whether it should keep correcting
     words and the traversal direction can be changed with C-u.
   - flyspell-correct-at-point :: offers corrections for word at point
     using the interface.
   - flyspell-correct-previous, flyspell-correct-next :: offers
     corrections for any incorrect word before or after point.

   It fixes a couple issues I have with the current Ispell / flyspell
   interface:
   - Many of the flyspell commands default to showing a GUI menu
   - Many of the flyspell commands like
     `flyspell-correct-word-before-point' won't correct a word too far
     away from point
   - M-x ispell will start from the beginning of the buffer instead of
     at point, possibly many marked words away from the one you
     intended to correct

 - flyspell-correct-avy-menu
 - flyspell-correct-helm
 - flyspell-correct-ido
 - flyspell-correct-ivy
 - flyspell-correct-popup

   These implement a simple `flyspell-correct-interface' for the given
   package postfix.
 

>> [1] https://github.com/mrkkrp/avy-menu
>> [2] https://github.com/d12frosted/flyspell-correct
>>
>> From de3ab4d80895b09b47172140d06cfe02d6b061e8 Mon Sep 17 00:00:00 2001
>> From: Jai Flack <jflack@disroot.org>
>> Date: Mon, 16 May 2022 13:46:39 +1000
>> Subject: [PATCH] * elpa-packages (avy-menu): New package
>>
>> ---
>>  elpa-packages | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/elpa-packages b/elpa-packages
>> index 734584008d..7c1b7128d6 100644
>> --- a/elpa-packages
>> +++ b/elpa-packages
>> @@ -45,6 +45,9 @@
>>   ("autothemer"          :url "https://github.com/jasonm23/autothemer.git"
>>    :readme "readme.md")
>>  
>> + ("avy-menu"		:url "https://github.com/mrkkrp/avy-menu"
>> +  :ignored-files (".github" "default.nix"))
>> +
>>   ("better-jumper"       :url "https://github.com/gilbertw1/better-jumper.git"
>>    :readme "Readme.md"
>>    :ignored-files ("LICENSE"))
>> -- 
>> 2.30.2
>>
>>
>> From 466ab8a0a1e2694b34e74109f7460802b1212a85 Mon Sep 17 00:00:00 2001
>> From: Jai Flack <jflack@disroot.org>
>> Date: Mon, 16 May 2022 13:09:02 +1000
>> Subject: [PATCH] * elpa-packages (flyspell-correct): New package
>>
>> * elpa-packages (flyspell-correct-avy-menu): New package
>> * elpa-packages (flyspell-correct-helm): New package
>> * elpa-packages (flyspell-correct-ido): New package
>> * elpa-packages (flyspell-correct-ivy): New package
>> * elpa-packages (flyspell-correct-popup): New package
>> ---
>>  elpa-packages | 42 ++++++++++++++++++++++++++++++++++++++++++
>>  1 file changed, 42 insertions(+)
>>
>> diff --git a/elpa-packages b/elpa-packages
>> index 7c1b7128d6..3fa6a7c994 100644
>> --- a/elpa-packages
>> +++ b/elpa-packages
>> @@ -163,6 +163,48 @@
>>   ("flymake-kondor"	:url "https://github.com/turbo-cafe/flymake-kondor"
>>    :ignored-files ("COPYING.txt"))
>>  
>> + ("flyspell-correct"	:url "https://github.com/d12frosted/flyspell-correct"
>> +  :news "CHANGELOG.org"
>> +  :ignored-files (".github" "images" "test" "Cask" "LICENSE.md" "Makefile"
>> +                  "flyspell-correct-avy-menu.el" "flyspell-correct-helm.el"
>> +                  "flyspell-correct-ido.el" "flyspell-correct-ivy.el"
>> +                  "flyspell-correct-popup.el" "makem.sh"))
>
> These specifications could be simplified if you were to use separate
> branches for each package.

This is not my package. Unless you are suggesting I request this change
from upstream?

>> + ("flyspell-correct-avy-menu"	:url "https://github.com/d12frosted/flyspell-correct"
>> +  :news "CHANGELOG.org"
>> +  :ignored-files (".github" "images" "test" "Cask" "LICENSE.md" "Makefile"
>> +                  "flyspell-correct-helm.el" "flyspell-correct-ido.el"
>> +                  "flyspell-correct-ivy.el" "flyspell-correct-popup.el"
>> +                  "flyspell-correct.el" "makem.sh"))
>> +
>> + ("flyspell-correct-helm"	:url "https://github.com/d12frosted/flyspell-correct"
>> +  :news "CHANGELOG.org"
>> +  :ignored-files (".github" "images" "test" "Cask" "LICENSE.md" "Makefile"
>> +                  "flyspell-correct-avy-menu.el" "flyspell-correct-ido.el"
>> +                  "flyspell-correct-ivy.el" "flyspell-correct-popup.el"
>> +                  "flyspell-correct.el" "makem.sh"))
>> +
>> + ("flyspell-correct-ido"	:url "https://github.com/d12frosted/flyspell-correct"
>> +  :news "CHANGELOG.org"
>> +  :ignored-files (".github" "images" "test" "Cask" "LICENSE.md" "Makefile"
>> +                  "flyspell-correct-avy-menu.el" "flyspell-correct-helm.el"
>> +                  "flyspell-correct-ivy.el" "flyspell-correct-popup.el"
>> +                  "flyspell-correct.el" "makem.sh"))
>> +
>> + ("flyspell-correct-ivy"	:url "https://github.com/d12frosted/flyspell-correct"
>> +  :news "CHANGELOG.org"
>> +  :ignored-files (".github" "images" "test" "Cask" "LICENSE.md" "Makefile"
>> +                  "flyspell-correct-avy-menu.el" "flyspell-correct-helm.el"
>> +                  "flyspell-correct-ido.el" "flyspell-correct-popup.el"
>> +                  "flyspell-correct.el" "makem.sh"))
>> +
>> + ("flyspell-correct-popup"	:url "https://github.com/d12frosted/flyspell-correct"
>> +  :news "CHANGELOG.org"
>> +  :ignored-files (".github" "images" "test" "Cask" "LICENSE.md" "Makefile"
>> +                  "flyspell-correct-avy-menu.el" "flyspell-correct-helm.el"
>> +                  "flyspell-correct-ido.el" "flyspell-correct-ivy.el"
>> +                  "flyspell-correct.el" "makem.sh"))
>> +
>>   ("forth-mode"          :url "https://github.com/larsbrinkhoff/forth-mode"
>>    :ignored-files ("test" "Makefile" "compile.el"))
>>  
>> -- 
>> 2.30.2

-- 
Thanks,
Jai



^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [NonGNU] New packages: avy-menu, flyspell-correct and friends
  2022-05-17  8:59   ` Jai Flack
@ 2022-05-17 18:32     ` Stefan Monnier
  2022-05-18 12:55       ` Jai Flack
  0 siblings, 1 reply; 12+ messages in thread
From: Stefan Monnier @ 2022-05-17 18:32 UTC (permalink / raw)
  To: Jai Flack; +Cc: Philip Kaludercic, emacs-devel

>  - flyspell-correct-avy-menu
>  - flyspell-correct-helm
>  - flyspell-correct-ido
>  - flyspell-correct-ivy
>  - flyspell-correct-popup
>
>    These implement a simple `flyspell-correct-interface' for the given
>    package postfix.

I think this goes back to the same question:

    Could you perhaps briefly explain what these packages do?
    Why the need for special helm, ido, ivy packages instead of using
    completing-read?


-- Stefan




^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [NonGNU] New packages: avy-menu, flyspell-correct and friends
  2022-05-17 18:32     ` Stefan Monnier
@ 2022-05-18 12:55       ` Jai Flack
  2022-05-20 13:19         ` Rudolf Adamkovič
  0 siblings, 1 reply; 12+ messages in thread
From: Jai Flack @ 2022-05-18 12:55 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: Philip Kaludercic, emacs-devel

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>>  - flyspell-correct-avy-menu
>>  - flyspell-correct-helm
>>  - flyspell-correct-ido
>>  - flyspell-correct-ivy
>>  - flyspell-correct-popup
>>
>>    These implement a simple `flyspell-correct-interface' for the given
>>    package postfix.
>
> I think this goes back to the same question:
>
>     Could you perhaps briefly explain what these packages do?
>     Why the need for special helm, ido, ivy packages instead of using
>     completing-read?

The package does offer a completing-read interface in
flyspell-correct.el as a default.

The -helm and -ivy packages use the completion interface's extra
features to select the extra options ("Save", "Accept (session)",
"Accept (buffer)", "Skip", et. al.). For example to save the word with
the Ivy interface one can start the correction then press M-o s (the
equivalent on Helm is C-o RET).

The -ido interface additionally lets a user select replacements by
entering the corresponding number, similar to the M-x ispell interface.

I briefly described the -avy-menu interface in my last post.

-popup uses a little popup at point to select actions (with the popup
package already in NonGNU).

> -- Stefan

If you decide some of these extra interfaces are superfluous, I think
there is still benefit from having the base flyspell-correct package in
NonGNU.

-- 
Thanks,
Jai



^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [NonGNU] New packages: avy-menu, flyspell-correct and friends
  2022-05-18 12:55       ` Jai Flack
@ 2022-05-20 13:19         ` Rudolf Adamkovič
  2022-05-20 16:18           ` Philip Kaludercic
  0 siblings, 1 reply; 12+ messages in thread
From: Rudolf Adamkovič @ 2022-05-20 13:19 UTC (permalink / raw)
  To: Jai Flack, Stefan Monnier; +Cc: Philip Kaludercic, emacs-devel

Jai Flack <jflack@posteo.net> writes:

> The package does offer a completing-read interface in
> flyspell-correct.el as a default.

As a long-time user of the package, I would like to see it become a part of
vanilla Emacs, now that the standard completing read API exists.

Rudy
-- 
"Thinking is a momentary dismissal of irrelevancies."
-- Richard Buckminster Fuller, 1969

Rudolf Adamkovič <salutis@me.com> [he/him]
Studenohorská 25
84103 Bratislava
Slovakia



^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [NonGNU] New packages: avy-menu, flyspell-correct and friends
  2022-05-20 13:19         ` Rudolf Adamkovič
@ 2022-05-20 16:18           ` Philip Kaludercic
  2022-05-22  3:46             ` Jai Flack
  2022-05-22  3:57             ` Jai Flack
  0 siblings, 2 replies; 12+ messages in thread
From: Philip Kaludercic @ 2022-05-20 16:18 UTC (permalink / raw)
  To: Rudolf Adamkovič; +Cc: Jai Flack, Stefan Monnier, emacs-devel

Rudolf Adamkovič <salutis@me.com> writes:

> Jai Flack <jflack@posteo.net> writes:
>
>> The package does offer a completing-read interface in
>> flyspell-correct.el as a default.
>
> As a long-time user of the package, I would like to see it become a part of
> vanilla Emacs, now that the standard completing read API exists.

This is part of the reason why I wanted to see if there was a reason
against adding it to GNU ELPA first, and possibly the core later on.

> Rudy



^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [NonGNU] New packages: avy-menu, flyspell-correct and friends
  2022-05-20 16:18           ` Philip Kaludercic
@ 2022-05-22  3:46             ` Jai Flack
  2022-05-22  3:57             ` Jai Flack
  1 sibling, 0 replies; 12+ messages in thread
From: Jai Flack @ 2022-05-22  3:46 UTC (permalink / raw)
  To: Philip Kaludercic; +Cc: Rudolf Adamkovič, Stefan Monnier, emacs-devel

Philip Kaludercic <philipk@posteo.net> writes:

> Rudolf Adamkovič <salutis@me.com> writes:
>
>> Jai Flack <jflack@posteo.net> writes:
>>
>>> The package does offer a completing-read interface in
>>> flyspell-correct.el as a default.
>>
>> As a long-time user of the package, I would like to see it become a part of
>> vanilla Emacs, now that the standard completing read API exists.
>
> This is part of the reason why I wanted to see if there was a reason
> against adding it to GNU ELPA first, and possibly the core later on.
>
>> Rudy

They've already had some discussion about getting the package in GNU ELPA,
it seems three of the contributors have yet to respond (it is noted that
two of them have previously contributed to Emacs) and one can't have the
copyright assignment. Only considering flyspell-correct.el there is ~19
lines of nontrivial changes by the contributor that can't get copyright
assignment.

Provided they would be happy with it, what are the requirements for
rewriting this by someone with copyright assignment? Then
flyspell-correct could be brought into GNU ELPA and the alternative
interfaces could go into NonGNU ELPA. I will use their bug tracker to
see if the copyright assignment situation has changed.

-- 
Thanks,
Jai



^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [NonGNU] New packages: avy-menu, flyspell-correct and friends
  2022-05-20 16:18           ` Philip Kaludercic
  2022-05-22  3:46             ` Jai Flack
@ 2022-05-22  3:57             ` Jai Flack
  2022-05-22 12:53               ` Stefan Monnier
  1 sibling, 1 reply; 12+ messages in thread
From: Jai Flack @ 2022-05-22  3:57 UTC (permalink / raw)
  To: Philip Kaludercic; +Cc: Rudolf Adamkovič, Stefan Monnier, emacs-devel

One more thing: do we have a clear definition for "non-trivial
contributions"? Specifically I am asking if moving three lines to
later in a function counts as a "non-trivial contribution". If not I
believe the contributor that can't get copyright assignment will have
contributed less than 15 lines to flyspell-correct.el.

-- 
Thanks,
Jai



^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [NonGNU] New packages: avy-menu, flyspell-correct and friends
  2022-05-22  3:57             ` Jai Flack
@ 2022-05-22 12:53               ` Stefan Monnier
  2022-05-22 13:04                 ` Eli Zaretskii
  0 siblings, 1 reply; 12+ messages in thread
From: Stefan Monnier @ 2022-05-22 12:53 UTC (permalink / raw)
  To: Jai Flack; +Cc: Philip Kaludercic, Rudolf Adamkovič, emacs-devel

Jai Flack [2022-05-22 03:57:36] wrote:
> One more thing: do we have a clear definition for "non-trivial
> contributions"?

We define it as "equivalent to about 15 lines worth of code", where
equivalence should be understood in a kind of kolmogorov-complexity sense.

> Specifically I am asking if moving three lines to later in a function
> counts as a "non-trivial contribution".

Definitely not, and it doesn't count as 3 lines worth of code either.

> If not I believe the contributor that can't get copyright assignment
> will have contributed less than 15 lines to flyspell-correct.el.

That would be nice,


        Stefan




^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [NonGNU] New packages: avy-menu, flyspell-correct and friends
  2022-05-22 12:53               ` Stefan Monnier
@ 2022-05-22 13:04                 ` Eli Zaretskii
  2022-05-23 12:26                   ` Jai Flack
  0 siblings, 1 reply; 12+ messages in thread
From: Eli Zaretskii @ 2022-05-22 13:04 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: jflack, philipk, salutis, emacs-devel

> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: Philip Kaludercic <philipk@posteo.net>,  Rudolf Adamkovič <salutis@me.com>,  emacs-devel@gnu.org
> Date: Sun, 22 May 2022 08:53:51 -0400
> 
> Jai Flack [2022-05-22 03:57:36] wrote:
> > One more thing: do we have a clear definition for "non-trivial
> > contributions"?
> 
> We define it as "equivalent to about 15 lines worth of code", where
> equivalence should be understood in a kind of kolmogorov-complexity sense.

It's not just a line count: the nature of the "code" in those 15 lines
also matters.  They must express some real creative activity.  For
example, 15 lines of data that can be gleaned from some source don't
count.



^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [NonGNU] New packages: avy-menu, flyspell-correct and friends
  2022-05-22 13:04                 ` Eli Zaretskii
@ 2022-05-23 12:26                   ` Jai Flack
  0 siblings, 0 replies; 12+ messages in thread
From: Jai Flack @ 2022-05-23 12:26 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: Stefan Monnier, philipk, salutis, emacs-devel

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Stefan Monnier <monnier@iro.umontreal.ca>
>> Cc: Philip Kaludercic <philipk@posteo.net>, Rudolf Adamkovič <salutis@me.com>, emacs-devel@gnu.org
>> Date: Sun, 22 May 2022 08:53:51 -0400
>> 
>> Jai Flack [2022-05-22 03:57:36] wrote:
>> > One more thing: do we have a clear definition for "non-trivial
>> > contributions"?
>> 
>> We define it as "equivalent to about 15 lines worth of code", where
>> equivalence should be understood in a kind of kolmogorov-complexity sense.
>
> It's not just a line count: the nature of the "code" in those 15 lines
> also matters.  They must express some real creative activity.  For
> example, 15 lines of data that can be gleaned from some source don't
> count.

Right.  In that case copyright assignment for them shouldn't be a
problem, what can go in GNU ELPA vs. NonGNU ELPA is only dictated by the
dependencies.

The maintainer is working on submitting their copyright assignment
papers at the moment.

-- 
Thanks,
Jai



^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2022-05-23 12:26 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-16  3:51 [NonGNU] New packages: avy-menu, flyspell-correct and friends Jai Flack
2022-05-16 17:30 ` Philip Kaludercic
2022-05-17  8:59   ` Jai Flack
2022-05-17 18:32     ` Stefan Monnier
2022-05-18 12:55       ` Jai Flack
2022-05-20 13:19         ` Rudolf Adamkovič
2022-05-20 16:18           ` Philip Kaludercic
2022-05-22  3:46             ` Jai Flack
2022-05-22  3:57             ` Jai Flack
2022-05-22 12:53               ` Stefan Monnier
2022-05-22 13:04                 ` Eli Zaretskii
2022-05-23 12:26                   ` Jai Flack

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).