From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master 4803fba487 1/2: 'C-x v v' on a diff buffer commits it as a patch (bug#52349) Date: Tue, 30 Aug 2022 20:34:54 +0300 Message-ID: <83k06ptz29.fsf@gnu.org> References: <166171593185.16640.41619657947456727@vcs2.savannah.gnu.org> <20220828194533.23A6BC00889@vcs2.savannah.gnu.org> <87r10znm0y.fsf@gnus.org> <83fshfvvyn.fsf@gnu.org> <999d1cb2-6b7f-8020-5202-e919278d895e@yandex.ru> <83v8q9u1q8.fsf@gnu.org> <87a67ladep.fsf@gnus.org> <83o7w1u0k1.fsf@gnu.org> <875yi9ac74.fsf@gnus.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6139"; mail-complaints-to="usenet@ciao.gmane.io" Cc: dgutov@yandex.ru, ams@gnu.org, juri@jurta.org, emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Aug 30 19:48:09 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oT5LM-0001LT-ON for ged-emacs-devel@m.gmane-mx.org; Tue, 30 Aug 2022 19:48:08 +0200 Original-Received: from localhost ([::1]:55010 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oT5LL-0008S6-L1 for ged-emacs-devel@m.gmane-mx.org; Tue, 30 Aug 2022 13:48:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35004) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oT58I-0000yh-AB for emacs-devel@gnu.org; Tue, 30 Aug 2022 13:34:39 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:58550) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oT58F-00009m-Qp; Tue, 30 Aug 2022 13:34:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=EDdmvYsfA84b38i1e4d8RVm6X2JQZcDOlo30QQtMZxM=; b=pVQ9L72GFrDe +ohGnMUJmEKZz4dq8g7Gp3P66POSrcVK5nSiEw2L1FHnpf4PxKq4cfIiXOVAil/UHg84mC3RkiqQ1 Sl2qjCL0x8mWlQetwpGB4dfgryAC13j79zeeNfSetN4oGMPL/o4V9oN0XA6+HKXgriFHLsJIkHlDK bGhjRuBrzJkg6ik57TGyY7kBSV1VpBCszaiNZXBC7F2daLG5AJZfm6PemBOYuuhyks9YOuVnsFSb9 yW/A7qy56w1u6yNTHpneplyyzKOfYVR0XEiL5zOHj1giZmaR/sG5zdzX1gTsRmqmdZaovD8zfN4LG cUEjbOizoxADQ2ogDaw5Fw==; Original-Received: from [87.69.77.57] (port=4849 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oT58B-0004Qq-KQ; Tue, 30 Aug 2022 13:34:34 -0400 In-Reply-To: <875yi9ac74.fsf@gnus.org> (message from Lars Ingebrigtsen on Tue, 30 Aug 2022 19:11:27 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:294372 Archived-At: > From: Lars Ingebrigtsen > Cc: dgutov@yandex.ru, ams@gnu.org, juri@jurta.org, emacs-devel@gnu.org > Date: Tue, 30 Aug 2022 19:11:27 +0200 > > Eli Zaretskii writes: > > > And then show a message to the user saying something like > > > > Edit the diffs to leave only the hunks you want to commit, > > then type C-c to go ahead and commit them. > > In a recursive edit? Yes. > Sure, that's a possible interface, but I don't really see much practical > difference, except being less flexible. It's a more natural UI, IMO. > It's more flexible, and not more work for the user than what you're > proposing, as far as I can tell. But it's backward from the UI POV.