From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: anti-alias fix results in ugly scaled fonts Date: Sat, 15 Oct 2022 10:32:30 +0300 Message-ID: <83k0517d9t.fsf@gnu.org> References: <517174.1665805249@pental> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1925"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Stephen Gildea Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Oct 15 09:33:46 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ojbg2-0000IB-7S for ged-emacs-devel@m.gmane-mx.org; Sat, 15 Oct 2022 09:33:46 +0200 Original-Received: from localhost ([::1]:36258 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ojbg0-0003rK-Oc for ged-emacs-devel@m.gmane-mx.org; Sat, 15 Oct 2022 03:33:44 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38892) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ojbf2-0003A3-EH for emacs-devel@gnu.org; Sat, 15 Oct 2022 03:32:44 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:55408) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ojbf1-0001To-1a; Sat, 15 Oct 2022 03:32:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Z1QD1YTdogbXZxY00mFdqxXiUcg6hppbTglln108ews=; b=pBKkxxc9nl8j LDtTaL66U3BPf255sSW1D/lKFpk6uNjNeMBuHAFYlSe4QgiU3PMYumb9VMGlltnKIf2IBzTCtvcPO 5oyNV5LDueRTz7B5UGhlbpVFStxOryZuYS2nIEr86rCMPCl2nB7oT6p77l72jfPbZ2dhx9XMJPMUe V1IFACjOq7zyRtArE+3zRAFgq5BM4PzrL6AulOlHVdE2IDzxBj6oQhQ5mFRkenL5DCCSk1AnlV6E0 AwaEB00rEDY3lLEZFSVxw8NKbgeYRfzqDkDL5gDUGRHEDwb9nG5A6tvxvyC1SQW8xiw7M40t64s5t 0C3hD45Zdebp9vNZymR94w==; Original-Received: from [87.69.77.57] (port=1291 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ojbf0-0000ZN-8B; Sat, 15 Oct 2022 03:32:42 -0400 In-Reply-To: <517174.1665805249@pental> (message from Stephen Gildea on Fri, 14 Oct 2022 20:40:49 -0700) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:297762 Archived-At: > From: Stephen Gildea > Date: Fri, 14 Oct 2022 20:40:49 -0700 > > At HEAD, I get an ugly scaled font for my sans-serif text. > I noticed it in MH-E, and you can reproduce it as follows: > > emacs -Q -fn fixed --eval "(buffer-face-set 'variable-pitch)" > > Although the default font is specified on the command line as "fixed" > (from the misc-fixed X11 family of fonts), and the variable-pitch font > selected is not in the misc-fixed family, having "fixed" as the > default font affects the font selected for the "variable-pitch" face. > Which font it selects changed recently. > > This bug seems to have been introduced by commit 6b1ed2f2c9, > "Fix antialias face attribute when text is scaled", 27 August. > > In an Emacs built before that commit, the above command displays text > with a pretty sans-serif font. The above works fine on my system: I get a "fixed" font without the "--eval" argument, and variable-pitch font with it, as expected. It sounds like so do you, but you don't like the variable-pitch font you get, is that so? If so, then the problem is with the fonts you have installed, not necessarily with what Emacs produces. That is, assuming you do get variable-pitch font in the buffer, why are you saying that Emacs doesn't perform correctly? The font being "ugly" is something only you know. I'm guessing that what you see is due to some attributes of the "fixed" font used as the default face's font. The commit you identified as the culprit preserves the attributes of the original font which the face doesn't override, instead of throwing them away. So I think the pretty sans-serif font you wanted to see is rejected because it doesn't fit some of those attributes of the default face's font. Can you try figuring out which attribute(s) are those? It could be the :weight attribute, for example (the "medium" vs "regular" issue, which is new in Emacs 29), or maybe :size. > That commit undoes some of the changes that addressed bug#17973. > Bug#17973 fixed display of misc-fixed fonts. With that recent commit, > using misc-fixed fonts again breaks some faces. Please tell the details: which faces are broken and how? P.S. And why isn't this reported as a bug to the bug-tracker, instead of here?