From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Mistakes in commit log messages Date: Sat, 15 Apr 2023 10:08:08 +0300 Message-ID: <83jzydei7b.fsf@gnu.org> References: <835ya5m4p0.fsf@gnu.org> <83v8i4arzt.fsf@gnu.org> <838rezardu.fsf@gnu.org> <319d616d-9230-0a82-331f-0f57488e4c80@gmail.com> <834jpm9s1g.fsf@gnu.org> <83v8i28b3j.fsf@gnu.org> <693285d2-e50b-289d-4f3e-ddd817ddc75b@gmail.com> <48d4dffa-cfa8-7949-3043-a1efa937902d@gmail.com> <838rew5lak.fsf@gnu.org> <5adfbf6f-fbcb-f4e8-3662-48bd5eb6a269@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22734"; mail-complaints-to="usenet@ciao.gmane.io" Cc: acm@muc.de, emacs-devel@gnu.org To: Jim Porter Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Apr 15 09:08:55 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pna1n-0005ih-8h for ged-emacs-devel@m.gmane-mx.org; Sat, 15 Apr 2023 09:08:55 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pna17-0001tf-5q; Sat, 15 Apr 2023 03:08:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pna14-0001tW-Ju for emacs-devel@gnu.org; Sat, 15 Apr 2023 03:08:11 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pna13-0000LF-Oi; Sat, 15 Apr 2023 03:08:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Ub0azH6oEzyikxI2RkQcX17wflPamoSRh1/1dGPmlo0=; b=l4OUcF8w4Dqg oVW3SXSunZh9v7zN6hqNalu5l57tHhKffzuV1QXTY5jARuSg6ShJRofMjjjBqZkXS8pLjlBWHgdaI 2T1pUYMoirfwwPhscLiyzBDXcXp4kPY6bWzt8sS3uP6WpU2fqas0sQh58l0lpvMkWqlw9HyJGrqDT Z56DWbdbwQXsuceXRPMf15QXWyrIdLmTC9nPjNXRQUgRLW30I1Ph4/igtcVc1N53PAhiSfpGhRtpM Ua8hbedYfHhAQcZedkgUTu4+fVKdqJmvPs1zd8DhGHwaUjtojD6UZ1mmjFcunDuAFUgF67h44hcap DpnxcjqUfvlIVFdJ1rxxGw==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pna11-0001wO-CK; Sat, 15 Apr 2023 03:08:09 -0400 In-Reply-To: <5adfbf6f-fbcb-f4e8-3662-48bd5eb6a269@gmail.com> (message from Jim Porter on Fri, 14 Apr 2023 20:41:49 -0700) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:305324 Archived-At: > Date: Fri, 14 Apr 2023 20:41:49 -0700 > Cc: acm@muc.de, emacs-devel@gnu.org > From: Jim Porter > > > Also, it looks like your script doesn't recognize file names in a line > > that starts with a semi-colon, as in this commit: > > I fixed this case, though as far as I can tell, authors.el doesn't look > at lines like this. (I could be wrong, since I just read over that code > briefly.) authors.el ignores such lines because they don't appear in ChangeLog files: they are ignored when generating ChangeLog from the Git log. (authors.el works on ChangeLog* files, not on the Git logs.) But that doesn't mean we don't want the file names in those logs to be correct; this script we are discussing is not just for the benefit of producing AUTHORS with less manual work, it is about our commit logs being cleaner. Thanks.