From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Mistakes in commit log messages Date: Sat, 15 Apr 2023 14:00:06 +0300 Message-ID: <83jzydcsw9.fsf@gnu.org> References: <319d616d-9230-0a82-331f-0f57488e4c80@gmail.com> <834jpm9s1g.fsf@gnu.org> <83v8i28b3j.fsf@gnu.org> <693285d2-e50b-289d-4f3e-ddd817ddc75b@gmail.com> <48d4dffa-cfa8-7949-3043-a1efa937902d@gmail.com> <838rew5lak.fsf@gnu.org> <5adfbf6f-fbcb-f4e8-3662-48bd5eb6a269@gmail.com> <9c8826af-a160-d36f-7577-2bc5ec0c2004@gmail.com> <83ildxehvc.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8742"; mail-complaints-to="usenet@ciao.gmane.io" Cc: jporterbugs@gmail.com, emacs-devel@gnu.org To: Alan Mackenzie Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Apr 15 13:01:01 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pndeP-00026a-78 for ged-emacs-devel@m.gmane-mx.org; Sat, 15 Apr 2023 13:01:01 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pndda-0006lT-PP; Sat, 15 Apr 2023 07:00:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pnddZ-0006lJ-1O for emacs-devel@gnu.org; Sat, 15 Apr 2023 07:00:09 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pnddY-0006Ns-9O; Sat, 15 Apr 2023 07:00:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=ykWwLLiSRjVAiTmcwn+wUfOqy0s8WIGcdP1hGuyhnoY=; b=D1I7DGZJl1/s SP5BfMISX0uyOiqM4qtgC/rYk5gyelY//1ecwH5Htvimbd1MYmBXDwnREPbbESXVdP/4zckyfcwmL WQXIyVvxS9L46UFa+sfYdnRBGooJjnEXpQnh/xWbPNzu0tPQKXu5DonXcsQu6VNAuX7cXKXsrIoX9 1MoG/cCsCi+dNNWPs5vaZmJZwQwKn5LDt9q2mTWaE13DT7dU/N6EKDlDhZluZ57xzeqM0BsCcf7GN bHKx/D4D0PMBH4q7DDT/hegzWPjuHL8y2tBWQ3RsNTczmyzEy8Q25wBSxlTe/TXefpvsdtRv4vABZ V5c9mNcq2iy6QIOIE32z1Q==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pnddU-0004gV-VC; Sat, 15 Apr 2023 07:00:07 -0400 In-Reply-To: (message from Alan Mackenzie on Sat, 15 Apr 2023 10:44:42 +0000) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:305328 Archived-At: > Date: Sat, 15 Apr 2023 10:44:42 +0000 > Cc: Jim Porter , emacs-devel@gnu.org > From: Alan Mackenzie > > > Btw, Alan, this is a good example of your log messages, which are > > filled using a much larger value of fill-column that the default. The > > resulting ChangeLog entries appear ugly and stand out from the rest. > > Would you please adjust your customizations to use a smaller > > fill-column value, like at most 76, when writing commit log messages? > > I've been using a fill-column of 78, to match the maximum allowed width. When we produce ChangeLog from the Git logs, the messages are indented on tab stop, so 78 is way too large. Even just "git log" will show you that 78 is too large, since Git indents the log messages by 4 spaces. > I'll try cutting that down to 63, as recommended in CONTRIBUTE. Thank you.