unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Yuan Fu <casouri@gmail.com>
Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org,
	mickey@masteringemacs.org, theo@thornhill.no, dgutov@yandex.ru
Subject: Re: Extending define-derived-mode
Date: Fri, 02 Jun 2023 14:51:17 +0300	[thread overview]
Message-ID: <83jzwmaxqi.fsf@gnu.org> (raw)
In-Reply-To: <C4869441-7F23-41EE-9E0E-30FAF6676CD0@gmail.com> (message from Yuan Fu on Fri, 2 Jun 2023 00:45:31 -0700)

> From: Yuan Fu <casouri@gmail.com>
> Date: Fri, 2 Jun 2023 00:45:31 -0700
> Cc: Stefan Monnier <monnier@iro.umontreal.ca>,
>  emacs-devel@gnu.org,
>  mickey@masteringemacs.org,
>  theo@thornhill.no,
>  dgutov@yandex.ru
> 
> >> I don’t entirely understand the example. Say I have a xxx-base-mode, and I want to setup menu-bar menus in it to be shared by xxx-mode and xxx-ts-mode. What is the problem that I’m gonna run into? Couldn’t you just use the base-mode’s keymap?
> > 
> > A base mode usually doesn't have a map, only the actually used derived
> > modes do.
> 
> We can create a map for the base mode, and the child mode’s map will inherit from it.

We can, but it won't solve the basic problem.

This sub-thread comes from me explaining why this presents a problem
for, e.g., defining menu-bar items, remember?  So, if we examine the
issue in that context, you will see that creating a map for the base
mode has the following downsides:

 . It can only have bindings for the commands that are identical in
   all child modes, something that normally isn't the case.  For
   example "C-c C-q" is bound in both c-mode and c-ts-mode, but to
   different commands.
 . The menu items you can define in the base mode can therefore only
   reference commands bound in the base mode's map, which once again
   means only identical commands.  For example, compare the menu items
   in the "C/C++" menu-bar menu of c-ts-mode with those in the "C"
   menu of c-mode, and you will see what I mean.

This is why it makes sense to define the bindings and menus in the
child modes, not in the common base mode: in many cases the same key
sequences and menu items will be bound to different commands.

Likewise with buffer-local variables: in many cases they will have
different values for different modes, and sometimes even different
names, although their functions and effects could be very similar or
identical.

Bottom line: based on our experience to this point, it sounds like at
least in some cases the differences between the non-TS mode and TS
mode supporting the same language is significant enough to make the
idea of inheriting from a common base mode problematic if not
impractical.



  reply	other threads:[~2023-06-02 11:51 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-30  5:16 Extending define-derived-mode Yuan Fu
2023-05-30  5:51 ` Theodor Thornhill
2023-05-31 20:35   ` Yuan Fu
2023-06-01  5:43     ` Theodor Thornhill
2023-05-30 10:48 ` Eli Zaretskii
2023-05-30 14:16   ` Stefan Monnier
2023-05-31 21:31     ` Yuan Fu
2023-06-01  4:06       ` Stefan Monnier
2023-06-01  6:39         ` Eli Zaretskii
2023-06-02  7:50           ` Yuan Fu
2023-06-02 11:54             ` Eli Zaretskii
2023-06-05  7:31               ` Yuan Fu
2023-06-05 11:33                 ` Eli Zaretskii
2023-06-08  7:25                   ` Yuan Fu
2023-06-02  7:44         ` Yuan Fu
2023-06-02 16:46           ` Stefan Monnier
2023-06-05  7:39             ` Yuan Fu
2023-06-05 15:17               ` Stefan Monnier
2023-05-31 20:48   ` Yuan Fu
2023-06-01  5:47     ` Eli Zaretskii
2023-06-02  7:45       ` Yuan Fu
2023-06-02 11:51         ` Eli Zaretskii [this message]
2023-05-30 17:24 ` Juri Linkov
2023-06-05  8:30 ` Philip Kaludercic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83jzwmaxqi.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=casouri@gmail.com \
    --cc=dgutov@yandex.ru \
    --cc=emacs-devel@gnu.org \
    --cc=mickey@masteringemacs.org \
    --cc=monnier@iro.umontreal.ca \
    --cc=theo@thornhill.no \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).