From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Make ispell localwords safe local variable Date: Wed, 16 Aug 2023 15:20:45 +0300 Message-ID: <83jztv89gi.fsf@gnu.org> References: <87zg2s97x0.fsf@breatheoutbreathe.in> <83o7j8a59k.fsf@gnu.org> <87h6ozdalc.fsf@breatheoutbreathe.in> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3107"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Joseph Turner Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Aug 16 14:21:22 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qWFWb-0000Tq-NT for ged-emacs-devel@m.gmane-mx.org; Wed, 16 Aug 2023 14:21:21 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qWFVy-00063B-S5; Wed, 16 Aug 2023 08:20:42 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qWFVw-0005sA-SW for emacs-devel@gnu.org; Wed, 16 Aug 2023 08:20:40 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qWFVv-0005Lu-UM; Wed, 16 Aug 2023 08:20:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=aO8KxzpSwTIghrnWzYuChmrvCFE09VdEBMCuiwsMXDQ=; b=marIPi7KOApS X6DLUQFFxlqIGDUxhW7AMXYRJ7TjiIb2fnPXii7PwAU3XK6cD2YeZoe4iwV5yT8fy9VGDLaRmB6/e C+jxtdsB7n/3kIw/BQ1KHkNKEBg2tkiK2MI4Uu/c65J/4Cj4J6YE1eHpPpKGtCsH63gdnWHFPismh Zi52LZ/rqWh4MSEoOgYp2vJmhU+d4ehGqoyThUUU8KUPmPAs8/Pd62ADaWVlkhzzkHMJKHV8w0bcy lpAWRsW13HJykhMFn35hTOeMm0pt25+bksA8s7NdYOHiAuyObPm8HljzcuSpXgityCGYhvI7Og/oy BW5GRTRzeLn20M2spVG2FA==; In-Reply-To: <87h6ozdalc.fsf@breatheoutbreathe.in> (message from Joseph Turner on Tue, 15 Aug 2023 18:41:18 -0700) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:308815 Archived-At: > From: Joseph Turner > Cc: emacs-devel@gnu.org > Date: Tue, 15 Aug 2023 18:41:18 -0700 > > > Eli Zaretskii writes: > > >> From: Joseph Turner > >> Date: Mon, 14 Aug 2023 22:40:24 -0700 > >> > >> In this PR , we made it > >> possible for checkdoc/ispell to ignore localwords stored in a > >> .dir-locals.el when run in batch mode. > >> > >> It seemed appropriate to upstream this fix. > > > > I'm not sure this is indeed safe enough. We send these words to the > > spell-checker; are we sure this couldn't be abused by malicious people > > to perform some destructive actions? > > I am not sure. Unless someone can be certain that ispell can safely > handle arbitrary strings, I think it's prudent to discard this patch. Does anyone else have an opinion about this?