unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: "Dr. Arne Babenhauserheide" <arne_bab@web.de>
Cc: dmitry@gutov.dev, emacs-devel@gnu.org
Subject: Re: VC registered, but ignored
Date: Thu, 31 Aug 2023 19:49:16 +0300	[thread overview]
Message-ID: <83jztbcg37.fsf@gnu.org> (raw)
In-Reply-To: <87o7indvmt.fsf@web.de> (arne_bab@web.de)

> From: "Dr. Arne Babenhauserheide" <arne_bab@web.de>
> Cc: Dmitry Gutov <dmitry@gutov.dev>, emacs-devel@gnu.org
> Date: Thu, 31 Aug 2023 18:23:51 +0200
> 
> This looks good, but I’m not sure about the !:
> 
> > +           ((eq state 'ignored)
> > +            (setq state-echo "File tracked by the VC system, but ignored")
> > +            (setq face 'vc-ignored-state)
> > +            (concat backend-name "!" rev))
> 
> I know ! as meaning "missing file". How about "i"? (small ignored)
> 
> ! is already used:
> 
>            ((eq state 'conflict)
>             (setq state-echo "File contains conflicts after the last merge")
> 	    (setq face 'vc-conflict-state)
>             (concat backend-name "!" rev))
>            ((eq state 'removed)
>             (setq state-echo "File removed from the VC system")
> 	    (setq face 'vc-removed-state)
>             (concat backend-name "!" rev))

My interpretation of the two cases which use "!" is that these states
are unusual and want to attract attention.  But then so is the
"registered, but ignored" situation: normally, ignored files are not
registered, and so will never have the vc-mode part on the mode line.
Which is why I used "!" for it as well.

I'm okay with any other character, but I think it has to be a
punctuation character, otherwise it might be interpreted as part of
the backend's name.



  reply	other threads:[~2023-08-31 16:49 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-31 15:24 VC registered, but ignored Eli Zaretskii
2023-08-31 16:23 ` Dr. Arne Babenhauserheide
2023-08-31 16:49   ` Eli Zaretskii [this message]
2023-09-01  1:03 ` Dmitry Gutov
2023-09-01  6:29   ` Eli Zaretskii
2023-09-01  9:16     ` Dmitry Gutov
2023-09-01 11:33       ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83jztbcg37.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=arne_bab@web.de \
    --cc=dmitry@gutov.dev \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).