From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Buffer size limitation in insdel.c Date: Thu, 23 Sep 2010 14:15:19 +0200 Message-ID: <83iq1wvep4.fsf@gnu.org> References: <834odivv7v.fsf@gnu.org> <83r5gkvqpf.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: dough.gmane.org 1285244214 8876 80.91.229.12 (23 Sep 2010 12:16:54 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 23 Sep 2010 12:16:54 +0000 (UTC) Cc: emacs-devel@gnu.org To: Lars Magne Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Sep 23 14:16:53 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OykjM-0003cE-JM for ged-emacs-devel@m.gmane.org; Thu, 23 Sep 2010 14:16:52 +0200 Original-Received: from localhost ([127.0.0.1]:45958 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OykjL-0000Ki-Qe for ged-emacs-devel@m.gmane.org; Thu, 23 Sep 2010 08:16:51 -0400 Original-Received: from [140.186.70.92] (port=41218 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OykiI-0008HT-7w for emacs-devel@gnu.org; Thu, 23 Sep 2010 08:15:49 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OykiE-0005iv-2x for emacs-devel@gnu.org; Thu, 23 Sep 2010 08:15:46 -0400 Original-Received: from mtaout21.012.net.il ([80.179.55.169]:59055) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OykiD-0005iY-Qz for emacs-devel@gnu.org; Thu, 23 Sep 2010 08:15:42 -0400 Original-Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0L9700D008KORA00@a-mtaout21.012.net.il> for emacs-devel@gnu.org; Thu, 23 Sep 2010 14:15:15 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([77.127.203.3]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0L9700DM18PEOB60@a-mtaout21.012.net.il>; Thu, 23 Sep 2010 14:15:15 +0200 (IST) In-reply-to: X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 (beta) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:130657 Archived-At: > From: Lars Magne Ingebrigtsen > Date: Thu, 23 Sep 2010 12:59:56 +0200 > > There were no comments on my -Wconversion post, so I thought there was > no interest in making the int/EMACS_INT overflows go away. You have a lot to learn about the corporate culture here ;-) Lack of response does not necessarily mean lack of interest. It just means no one volunteers yet. > The bugs are trivial to find with -Wconversion, and most of them are > easy enough to fix. But some may be more subtle? Some are, indeed. But those are few and far in between. > A methodology to fix this up with be for us to compile with > -Wconversion, pick a file, any file, to work on, fix all the > -Wconversion warnings in that file, and then see if Emacs still works. > > Then check in and move on to the next file. :-) > > I'm up for taking a few files, but I'm not up for doing all 5400 > warnings. I already started, feel free to join, and thanks. For now, I simply go through the sources by hand, it's easy enough to spot the obvious problems. In a nutshell, any variable declared as `int' is a suspect, at least in some source files that are frequent offenders. When this is out of my way, I will use -Wconversion. That sounds easier than going through 5000 warnings; YMMV.