From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Failed to compile from last bzr repo Date: Wed, 06 Apr 2011 06:01:48 +0300 Message-ID: <83ipusulpf.fsf@gnu.org> References: <87vcyugxgs.fsf@gnu.org> <87wrjab38x.fsf@gmail.com> <83d3l1x6i6.fsf@gnu.org> <87pqp07lmg.fsf@gmail.com> <83tyecvdwj.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE X-Trace: dough.gmane.org 1302058922 31992 80.91.229.12 (6 Apr 2011 03:02:02 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 6 Apr 2011 03:02:02 +0000 (UTC) Cc: sean.sieger@gmail.com, monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Juanma Barranquero Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Apr 06 05:01:50 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Q7J0A-0004QR-AZ for ged-emacs-devel@m.gmane.org; Wed, 06 Apr 2011 05:01:50 +0200 Original-Received: from localhost ([127.0.0.1]:59007 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q7J09-0001y5-QE for ged-emacs-devel@m.gmane.org; Tue, 05 Apr 2011 23:01:49 -0400 Original-Received: from [140.186.70.92] (port=34824 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q7J04-0001uj-SZ for emacs-devel@gnu.org; Tue, 05 Apr 2011 23:01:45 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q7J04-0005ns-4O for emacs-devel@gnu.org; Tue, 05 Apr 2011 23:01:44 -0400 Original-Received: from mtaout22.012.net.il ([80.179.55.172]:39429) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q7J03-0005nj-So for emacs-devel@gnu.org; Tue, 05 Apr 2011 23:01:44 -0400 Original-Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0LJ700F00MLQZP00@a-mtaout22.012.net.il> for emacs-devel@gnu.org; Wed, 06 Apr 2011 06:01:42 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([77.126.47.180]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LJ700FAWN2SI4B0@a-mtaout22.012.net.il>; Wed, 06 Apr 2011 06:01:42 +0300 (IDT) In-reply-to: X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 (beta) X-Received-From: 80.179.55.172 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:138204 Archived-At: > From: Juanma Barranquero > Date: Wed, 6 Apr 2011 00:45:46 +0200 > Cc: sean.sieger@gmail.com, monnier@iro.umontreal.ca, emacs-devel@gn= u.org >=20 > > =C2=A0#ifdef GLYPH_DEBUG > > =C2=A0# undef GLYPH_DEBUG > > =C2=A0# define GLYPH_DEBUG 1 > > =C2=A0#endif > > > > Then a simple "--cflags -DGLYPH_DEBUG" option to configure will d= o. >=20 > Good idea, though in the long term we must find a way to pass -DX= =3DY to > configure.bat. Either having a separate --define option which grabs > two values, or by reading options from an environment variable, lik= e > someone recently sugested. I think the above is much easier than any of the alternatives. In particular, setting an environment variable sounds both ugly and dangerous to me (the risk of leaving it set is high).