From: Eli Zaretskii <eliz@gnu.org>
To: Dmitry Antipov <dmantipov@yandex.ru>
Cc: emacs-devel@gnu.org
Subject: Re: Why buffer_shared is a mistake
Date: Sat, 08 Dec 2012 15:58:12 +0200 [thread overview]
Message-ID: <83ip8clk7f.fsf@gnu.org> (raw)
In-Reply-To: <50C0C196.2020400@yandex.ru>
> Date: Thu, 06 Dec 2012 20:02:30 +0400
> From: Dmitry Antipov <dmantipov@yandex.ru>
> CC: Eli Zaretskii <eliz@gnu.org>
>
> 1) Redisplay is invoked with "xaxa" as current_buffer, and buffer_shared is recalculated
> to 2 because "xaxa" is displayed in 2 windows. On leaving redisplay_internal, buffer_shared
> is 2.
>
> 2) modify_overlay is called for "*scratch*", and this function still sees buffer_shared as 2
> (unchanged since last redisplay invocation), although *scratch* is displayed in the only
> window.
>
> 3) ???
>
> IIUC, as the minimum minorum, buffer_shared should be reset to 0 after leaving redisplay_internal.
> Or it should be a per-buffer field.
buffer_shared is used only by xdisp.c, with the single exception of
modify_overlay. How about changing modify_overlay to compute this
value by itself?
IOW, I think modify_overlay shouldn't have used that variable to
begin with. It's an internal variable used by the display engine.
next prev parent reply other threads:[~2012-12-08 13:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-06 16:02 Why buffer_shared is a mistake Dmitry Antipov
2012-12-08 13:58 ` Eli Zaretskii [this message]
2012-12-10 7:29 ` Dmitry Antipov
2012-12-10 8:18 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83ip8clk7f.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=dmantipov@yandex.ru \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).