unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: selected-frame and selected-window
Date: Sun, 09 Dec 2012 05:50:38 +0200	[thread overview]
Message-ID: <83ip8bdgtt.fsf@gnu.org> (raw)
In-Reply-To: <jwv4njwds3w.fsf-monnier+emacs@gnu.org>

> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: emacs-devel@gnu.org
> Date: Sat, 08 Dec 2012 18:51:40 -0500
> 
> >> > This is assertion violation in redisplay_internal, here:
> >> >       eassert (EQ (XFRAME (selected_frame)->selected_window,
> >> >                    selected_window));
> >> > This crash is probably of the kind you reported in the past, related
> >> > to the selected-frame/selected-window issues.
> >> I'm not sure is that assertion is actually right.
> > Well, "bzr annotate" says you added it ;-)
> > Should we just go ahead and remove it?  Inaccurate assertions are a
> > maintenance headache, to say nothing of user aggravation.
> 
> The rest of my message mentioned reasons why the equality is
> sometimes broken.

Yes, I know.  But a broken assertion is a candidate for removal, IMO.

> Now, I tend to consider that those cases should be considered bugs,
> because IIRC there are cases where we do rely on this equality.

If you or someone else can describe those cases, we could use that
knowledge to modify the assertion or fix the bugs which violate it.

> More specifically, I added such easserts in an effort to track the
> origin of an error.

We are evidently unable to do that in a long time.  All we do is cause
user aggravation and add to maintenance load.

> But to fix these bugs we need to figure out how to handle the "mode-line
> :eval" case.

Do you have any practical suggestions for that?



  reply	other threads:[~2012-12-09  3:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <E434CEB9297E432AA3570AF8C351C084@us.oracle.com>
     [not found] ` <jwvlidynywq.fsf-monnier+emacs@gnu.org>
     [not found]   ` <83y5hyxnb1.fsf@gnu.org>
     [not found]     ` <jwvsj86me1m.fsf-monnier+emacs@gnu.org>
     [not found]       ` <83wqxhy4ha.fsf@gnu.org>
     [not found]         ` <jwv62513216.fsf-monnier+emacs@gnu.org>
     [not found]           ` <83fw45xxzk.fsf@gnu.org>
     [not found]             ` <jwv39051lyw.fsf-monnier+emacs@gnu.org>
     [not found]               ` <83ehjpxwqd.fsf@gnu.org>
     [not found]                 ` <jwvr4npz8az.fsf-monnier+emacs@gnu.org>
     [not found]                   ` <838v9xxss8.fsf@gnu.org>
     [not found]                     ` <jwvy5hxxpv3.fsf-monnier+emacs@gnu.org>
     [not found]                       ` <83zk2dvsba.fsf@gnu.org>
     [not found]                         ` <jwvd2z8na6f.fsf-monnier+emacs@gnu.org>
     [not found]                           ` <CAAeL0STTFjDRCjWUbQJOc1=YdF+M9JG6_BypOfr1X9_vQN+yeg@mail.gmail.com>
     [not found]                             ` <A5B77C60B99D463D8B4818431132BD6F@us.oracle.com>
     [not found]                               ` <83ip90w48g.fsf@gnu.org>
     [not found]                                 ` <4AB1E6AB8BB448AAB037D70CBECBFD9D@us.oracle.com>
     [not found]                                   ` <83d2z8w2na.fsf@gnu.org>
     [not found]                                     ` <CAH8Pv0j-ZFs1xSpsSFy3QW9MP3zDO6nzaNGvUtYr8-UTJ3ifWw@mail.gmail.com>
     [not found]                                       ` <837gpgvz81.fsf@gnu.org>
2012-11-20 20:37                                         ` selected-frame and selected-window Stefan Monnier
2012-11-21 17:05                                           ` Stefan Monnier
2012-12-08 12:24                                           ` Eli Zaretskii
2012-12-08 23:51                                             ` Stefan Monnier
2012-12-09  3:50                                               ` Eli Zaretskii [this message]
2012-12-14 15:53                                                 ` Stefan Monnier
2012-12-14 16:04                                                   ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83ip8bdgtt.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).