From: Eli Zaretskii <eliz@gnu.org>
To: Oleh Krehel <ohwoeowho@gmail.com>
Cc: monnier@IRO.UMontreal.CA, emacs-devel@gnu.org
Subject: Re: Is it time to remove INTERNAL_FIELD?
Date: Thu, 23 Apr 2015 16:53:38 +0300 [thread overview]
Message-ID: <83iocn0x3x.fsf@gnu.org> (raw)
In-Reply-To: <87fv7r3rbh.fsf@gmail.com>
> From: Oleh Krehel <ohwoeowho@gmail.com>
> Date: Thu, 23 Apr 2015 15:30:26 +0200
> Cc: emacs-devel@gnu.org
>
> we should remove the macros that don't do anything.
What this macro does is allow you to use field names like 'foo', when
the field is really called 'foo_'.
I think it's okay to remove INTERNAL_FIELD, but I think we should keep
the trailing underscore appended in BVAR and KVAR. That's how all
this started: the fields were renamed to have a trailing underscore so
that code that used foo->bar instead of BVAR (foo, bar) would be
immediately flagged by the compiler.
> As for accidental access, I'm sure these rare errors will be caught by
> the code review / test suite.
We don't want to rely on code reviews, since they are very informal
and their coverage is too low to be efficient.
Based on bitter past experience with similar errors that lay low for
months, sometimes for years, I'd rather not give up those underscores
in BVAR and KVAR, which means the struct fields should retain them.
next prev parent reply other threads:[~2015-04-23 13:53 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-23 9:55 Is it time to remove INTERNAL_FIELD? Oleh Krehel
2015-04-23 10:08 ` Paul Eggert
2015-04-23 10:10 ` Oleh Krehel
2015-04-23 10:17 ` Paul Eggert
2015-04-23 10:56 ` Eli Zaretskii
2015-04-23 10:56 ` Oleh Krehel
2015-04-23 11:17 ` Eli Zaretskii
2015-04-23 11:32 ` Oleh Krehel
2015-04-23 12:01 ` Eli Zaretskii
2015-04-23 12:05 ` Oleh Krehel
2015-04-23 12:37 ` Eli Zaretskii
2015-04-25 10:57 ` Oleh Krehel
2015-04-25 11:28 ` Eli Zaretskii
2015-04-25 14:28 ` Stefan Monnier
2015-04-25 14:41 ` Eli Zaretskii
2015-04-28 7:39 ` Oleh Krehel
2015-04-28 13:20 ` Stefan Monnier
2015-04-28 15:07 ` Eli Zaretskii
2015-04-28 15:11 ` Oleh Krehel
2015-04-28 15:23 ` Eli Zaretskii
2015-04-28 18:58 ` Oleh Krehel
2015-04-28 19:21 ` Eli Zaretskii
2015-04-23 11:00 ` Eli Zaretskii
2015-04-23 13:24 ` Stefan Monnier
2015-04-23 13:30 ` Oleh Krehel
2015-04-23 13:53 ` Eli Zaretskii [this message]
2015-04-23 14:07 ` Oleh Krehel
2015-04-23 14:50 ` Nicolas Richard
2015-04-23 15:34 ` Eli Zaretskii
2015-04-24 10:44 ` Nicolas Richard
2015-04-23 15:29 ` Eli Zaretskii
2015-04-23 16:32 ` Oleh Krehel
2015-04-23 17:00 ` Eli Zaretskii
2015-04-23 17:09 ` Oleh Krehel
2015-04-23 17:29 ` Eli Zaretskii
2015-04-23 17:14 ` Stefan Monnier
2015-04-23 17:31 ` Eli Zaretskii
2015-04-23 13:30 ` Stefan Monnier
2015-04-23 13:33 ` Oleh Krehel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83iocn0x3x.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@IRO.UMontreal.CA \
--cc=ohwoeowho@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).