From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Dynamic modules: MODULE_HANDLE_SIGNALS etc. Date: Fri, 27 Nov 2015 09:35:59 +0200 Message-ID: <83io4nuc68.fsf@gnu.org> References: <83mvu1x6t3.fsf@gnu.org> <565779CD.80405@cs.ucla.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1448609868 31040 80.91.229.3 (27 Nov 2015 07:37:48 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 27 Nov 2015 07:37:48 +0000 (UTC) Cc: aurelien.aptel+emacs@gmail.com, tzz@lifelogs.com, dancol@dancol.org, p.stephani2@gmail.com, emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Nov 27 08:37:32 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1a2Da3-0002nB-Os for ged-emacs-devel@m.gmane.org; Fri, 27 Nov 2015 08:36:33 +0100 Original-Received: from localhost ([::1]:55168 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a2Da6-0004aC-5m for ged-emacs-devel@m.gmane.org; Fri, 27 Nov 2015 02:36:34 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54639) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a2DZs-0004a5-2E for emacs-devel@gnu.org; Fri, 27 Nov 2015 02:36:20 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a2DZn-0006FQ-33 for emacs-devel@gnu.org; Fri, 27 Nov 2015 02:36:19 -0500 Original-Received: from mtaout23.012.net.il ([80.179.55.175]:57098) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a2DZm-0006DL-Re for emacs-devel@gnu.org; Fri, 27 Nov 2015 02:36:15 -0500 Original-Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0NYG00G00Q77CZ00@a-mtaout23.012.net.il> for emacs-devel@gnu.org; Fri, 27 Nov 2015 09:36:13 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([84.94.185.246]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NYG00GIHQGDAT40@a-mtaout23.012.net.il>; Fri, 27 Nov 2015 09:36:13 +0200 (IST) In-reply-to: <565779CD.80405@cs.ucla.edu> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 X-Received-From: 80.179.55.175 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:195344 Archived-At: > Cc: emacs-devel@gnu.org > From: Paul Eggert > Date: Thu, 26 Nov 2015 13:29:49 -0800 > > Eli Zaretskii wrote: > > it would be a maintenance burden to have to > > analyze upon each such change whether emacs-module.c needs some > > augmentation. > > While that's true in general, I think some exceptions are OK. E.g., it's OK if > emacs-module.c assumes that ASIZE is a simple access function or macro that > doesn't throw signals. If we actually changed ASIZE to throw signals, there's a > boatload of other code we'd need to change as well, and changing emacs-module.c > wouldn't add much more to the maintenance burden. So what are the rules here, exactly? I'd like to write them down in the commentary to emacs-module.c, so that any future changes there will have lower probability of breaking things. E.g., can make_number signal an error? What about make_float or make_string? And what about accessors like XFLOAT_DATA or AREF?