From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Compilation warnings in mouse.el Date: Wed, 13 Jul 2016 17:31:34 +0300 Message-ID: <83inw9a9tl.fsf@gnu.org> References: <8360scdzik.fsf@gnu.org> <87zipnzvo4.fsf@gmx.net> <8337nfcupy.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1468420417 19409 80.91.229.3 (13 Jul 2016 14:33:37 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 13 Jul 2016 14:33:37 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jul 13 16:33:30 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bNLE7-0003k7-C5 for ged-emacs-devel@m.gmane.org; Wed, 13 Jul 2016 16:33:27 +0200 Original-Received: from localhost ([::1]:48067 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bNLE1-0004Yv-Os for ged-emacs-devel@m.gmane.org; Wed, 13 Jul 2016 10:33:21 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46292) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bNLCe-0003zW-Rf for emacs-devel@gnu.org; Wed, 13 Jul 2016 10:32:00 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bNLCc-00031y-1O for emacs-devel@gnu.org; Wed, 13 Jul 2016 10:31:55 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:55299) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bNLCb-00031f-UX; Wed, 13 Jul 2016 10:31:53 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3831 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bNLCZ-0005GR-FW; Wed, 13 Jul 2016 10:31:52 -0400 In-reply-to: (message from Stefan Monnier on Tue, 12 Jul 2016 18:58:12 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:205632 Archived-At: > From: Stefan Monnier > Date: Tue, 12 Jul 2016 18:58:12 -0400 > > EZ> Unlike Stefan, I think we should add :group to every defcustom. Having > EZ> them mysteriously missing from some of them is a time bomb: > > The way I see it, defcustoms should pretty much never have :group, and > the group to which they belong is simply determined by the file in which > they occur. But as long as such a system isn't installed, we shouldn't behave as if it were. (And what you propose is not without downsides, I think.) > EZ> remove or add > EZ> enough defcustoms in the same file, and you have a bug. > > I don't see how removing/adding defcustoms in the same file > would introduce problems. We just saw such a problem, no? > PS: Incidentally, we have two definitions of the `mouse' group > in cus-edit.el: Thanks. Bonus points for fixing that.