From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master 0a5b6e2: Fix aborts in GC under GC_CHECK_MARKED_OBJECTS
Date: Thu, 22 Dec 2016 18:17:57 +0200 [thread overview]
Message-ID: <83inqc0wga.fsf@gnu.org> (raw)
In-Reply-To: <jwveg10fx3r.fsf-monnier+emacsdiffs@gnu.org> (message from Stefan Monnier on Wed, 21 Dec 2016 22:45:43 -0500)
> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: emacs-devel@gnu.org
> Date: Wed, 21 Dec 2016 22:45:43 -0500
>
> That there might be on the stack a Lisp_Object variable which holds
> a Lisp_Vectorlike references which is really a reference to a thread
> object, so the conservative GC would need to be able to recognize them,
> AFAICT. So your code doesn't make things worse, but I think that the
> problem detected by GC_CHECK_MARKED_OBJECTS needs to be fixed by adding
> thread objects to the red-black tree.
I think they already are in the tree: the thread object is a
Lisp_Vectorlike allocated from some block in vector_blocks, and all
the blocks there are already inserted into the tree. Other than that,
the few members of thread_state structure are just "normal" Lisp
objects, so they are also in the tree.
next prev parent reply other threads:[~2016-12-22 16:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20161221201813.3130.28327@vcs.savannah.gnu.org>
[not found] ` <20161221201813.A13CA2201BA@vcs.savannah.gnu.org>
2016-12-21 20:29 ` [Emacs-diffs] master 0a5b6e2: Fix aborts in GC under GC_CHECK_MARKED_OBJECTS Stefan Monnier
2016-12-21 20:40 ` Eli Zaretskii
2016-12-21 22:52 ` Stefan Monnier
2016-12-22 3:35 ` Eli Zaretskii
2016-12-22 3:45 ` Stefan Monnier
2016-12-22 16:17 ` Eli Zaretskii [this message]
2016-12-22 4:18 ` Daniel Colascione
2016-12-22 4:22 ` Daniel Colascione
2016-12-22 16:14 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83inqc0wga.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).