From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Skipping unexec via a big .elc file Date: Fri, 31 Mar 2017 09:57:27 +0300 Message-ID: <83inmq53xk.fsf@gnu.org> References: <9463F91F-DB82-48E1-BE01-1E2BC8DA0766@raeburn.org> <831swxzbw8.fsf@gnu.org> <83y3z2wphb.fsf@gnu.org> <83tw9bb42m.fsf@gnu.org> <349ED8B9-C34B-495B-9FB5-E72CE6EFCA38@raeburn.org> <87inpni6xa.fsf@linux-m68k.org> <8360lmesso.fsf@gnu.org> <3B044D64-7C94-42D7-BE1B-7A9CA76C5A67@raeburn.org> <83k29xc49v.fsf@gnu.org> <2C5C5C6E-9D73-4613-948B-C15B93968717@raeburn.org> <83poiy8cnv.fsf@gnu.org> <83r32mqq5f.fsf@gnu.org> <83zih1jf37.fsf@gnu.org> <8A8DA980-13A7-4F8B-9D07-391728C673C9@raeburn.org> <831su4dmn4.fsf@gnu.org> <87h9300x5n.fsf@linux-m68k.org> <734D2132-71FD-414D-B091-629189742DB4@raeburn.org> <83a8889ede.fsf@gnu.org> <144D5F87-D876-485D-BAB3-2AA93627272A@raeburn.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1490943484 10394 195.159.176.226 (31 Mar 2017 06:58:04 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 31 Mar 2017 06:58:04 +0000 (UTC) Cc: emacs-devel@gnu.org To: Ken Raeburn Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Mar 31 08:58:00 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ctqVS-0001zZ-F8 for ged-emacs-devel@m.gmane.org; Fri, 31 Mar 2017 08:57:58 +0200 Original-Received: from localhost ([::1]:39150 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ctqVV-0002pw-H6 for ged-emacs-devel@m.gmane.org; Fri, 31 Mar 2017 02:58:01 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56908) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ctqV0-0002pq-BT for emacs-devel@gnu.org; Fri, 31 Mar 2017 02:57:31 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ctqUx-0006J6-9h for emacs-devel@gnu.org; Fri, 31 Mar 2017 02:57:30 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:43530) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ctqUx-0006Iv-66; Fri, 31 Mar 2017 02:57:27 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2043 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ctqUw-0003Bp-Di; Fri, 31 Mar 2017 02:57:26 -0400 In-reply-to: <144D5F87-D876-485D-BAB3-2AA93627272A@raeburn.org> (message from Ken Raeburn on Mon, 27 Mar 2017 22:27:26 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:213547 Archived-At: > From: Ken Raeburn > Date: Mon, 27 Mar 2017 22:27:26 -0400 > Cc: emacs-devel@gnu.org > > > I applied your patch, and while dumping I get an error message: > > > > Dumping into dumped.elc...preparing... > > Dumping into dumped.elc...generating... > > Symbol's function definition is void: cl-labels > > > > and dumped.elc is not re-created. What did I miss? > > Looks like I missed a “require” or “load” to pull in cl-macs. Perhaps it’s loaded by something else in my build that’s platform-dependent (X11 vs Windows?) and isn’t in yours; I’m not sure. But it isn’t working for me to just load it explicitly without fixing up the load path too. Perhaps I should’ve just defined a helper function instead of using cl-labels. > > For now, try adding this patch. It bootstraps for me, and should get cl-labels defined. This fixes the problem, and Emacs now starts OK, so the abbrevs issue is also solved. I think you should push all the changes you asked me to apply as patches. What is the roadmap ahead? Are there any known issues left, before we can consider this be a candidate for merging to master, and asking people to test it in their routine workflows before we actually merge? Thanks.