From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Advice needed on modeline customization hack... Date: Mon, 17 Apr 2017 17:17:23 +0300 Message-ID: <83inm3dsp8.fsf@gnu.org> References: <20170415212800.5be89037@jabberwock.cb.piermont.com> <20170416094929.51e94c82@jabberwock.cb.piermont.com> <20170416104633.1768bbb6@jabberwock.cb.piermont.com> <20170416120942.36af8967@jabberwock.cb.piermont.com> <20170416180620.3615b4b6@jabberwock.cb.piermont.com> <20170416181607.4ca1971e@jabberwock.cb.piermont.com> <20170416185740.7d848393@jabberwock.cb.piermont.com> <83ziffefpj.fsf@gnu.org> <20170417085326.1e3c4b30@jabberwock.cb.piermont.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1492438623 5635 195.159.176.226 (17 Apr 2017 14:17:03 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 17 Apr 2017 14:17:03 +0000 (UTC) Cc: cpitclaudel@gmail.com, monnier@iro.umontreal.ca, emacs-devel@gnu.org To: "Perry E. Metzger" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Apr 17 16:16:59 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d07Sc-0001N3-MV for ged-emacs-devel@m.gmane.org; Mon, 17 Apr 2017 16:16:58 +0200 Original-Received: from localhost ([::1]:36780 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d07Si-0000Pn-Dj for ged-emacs-devel@m.gmane.org; Mon, 17 Apr 2017 10:17:04 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36948) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d07Sc-0000P0-9b for emacs-devel@gnu.org; Mon, 17 Apr 2017 10:16:59 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d07SY-0005s0-5p for emacs-devel@gnu.org; Mon, 17 Apr 2017 10:16:58 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:45269) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d07SY-0005rw-2a; Mon, 17 Apr 2017 10:16:54 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1568 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1d07SW-0000dW-6f; Mon, 17 Apr 2017 10:16:53 -0400 In-reply-to: <20170417085326.1e3c4b30@jabberwock.cb.piermont.com> (perry@piermont.com) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:214060 Archived-At: > Date: Mon, 17 Apr 2017 08:53:26 -0400 > From: "Perry E. Metzger" > Cc: cpitclaudel@gmail.com, monnier@iro.umontreal.ca, emacs-devel@gnu.org > > > Please also add a NEWS entry about this new option. > > Will write one. How does one do a patch for that, given that by the > time this is applied it may be in the wrong place? Or should I just > include the blurb and whomever does the commit will add it? The place where the entry ends up isn't important, because usually NEWS entries get rearranged shortly before the release anyway. > > I think it's best to have > > it in xdisp.c, where the feature is implemented, in which case you > > should add the necessary stuff to cus-start.el to allow its > > customization by Custom. > > I thought that since the rest of the lisp side was done there > (including the minor mode) that it was better to have it in the .el > file. Do you have a strong opinion? It isn't a strong opinion, it just will make it easier to find the implementation given the option and vice versa. We do have exceptions from this semi-rule, so this could be another one. > > What about the required change to mode_line_update_needed? > > I no longer need that since I now only increment the column number for > the routine that generates the modeline string and not for the > variable in the window structure. See the patch for details. Right you are, sorry for missing that.