From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: libnettle/libhogweed WIP Date: Fri, 14 Jul 2017 22:04:50 +0300 Message-ID: <83iniug7ql.fsf@gnu.org> References: <834lxndmd9.fsf@gnu.org> <87efwrug6z.fsf@lifelogs.com> <87r30qu5av.fsf@lifelogs.com> <874lxmtxyy.fsf@lifelogs.com> <87r30prvwt.fsf@lifelogs.com> <8337d4csez.fsf@gnu.org> <87r30nq9el.fsf@lifelogs.com> <83inlyc1k2.fsf@gnu.org> <87inlyrfni.fsf@lifelogs.com> <837f2eb845.fsf@gnu.org> <87ziedpyy1.fsf@lifelogs.com> <83d1b75u8a.fsf@gnu.org> <87r2znntaq.fsf@lifelogs.com> <87o9u8q4a5.fsf@lifelogs.com> <83tw3xbklg.fsf@gnu.org> <87zictm415.fsf@lifelogs.com> <83podoqchd.fsf@gnu.org> <87podnnbi2.fsf@lifelogs.com> <8760ewi3rw.fsf@lifelogs.com> <87r2xjgilq.fsf@lifelogs.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1500059128 28853 195.159.176.226 (14 Jul 2017 19:05:28 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 14 Jul 2017 19:05:28 +0000 (UTC) Cc: emacs-devel@gnu.org To: Ted Zlatanov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jul 14 21:05:22 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dW5ty-0007I4-7H for ged-emacs-devel@m.gmane.org; Fri, 14 Jul 2017 21:05:22 +0200 Original-Received: from localhost ([::1]:39527 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dW5u3-0000HZ-Nq for ged-emacs-devel@m.gmane.org; Fri, 14 Jul 2017 15:05:27 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53243) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dW5tT-0000HT-MP for emacs-devel@gnu.org; Fri, 14 Jul 2017 15:04:52 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dW5tQ-0000xm-HP for emacs-devel@gnu.org; Fri, 14 Jul 2017 15:04:51 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:45077) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dW5tQ-0000xf-Ei; Fri, 14 Jul 2017 15:04:48 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4844 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dW5tP-00037S-RC; Fri, 14 Jul 2017 15:04:48 -0400 In-reply-to: <87r2xjgilq.fsf@lifelogs.com> (message from Ted Zlatanov on Fri, 14 Jul 2017 11:10:09 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:216658 Archived-At: > From: Ted Zlatanov > Date: Fri, 14 Jul 2017 11:10:09 -0400 > > On Thu, 13 Jul 2017 14:35:15 -0400 Ted Zlatanov wrote: > > TZ> The code in the branch scratch/tzz/nettle is ready for merge and I > TZ> waited a few weeks since making the last round of changes. It has tests > TZ> you can review to see the API and usage. > > TZ> Barring any objections, I'll rebase+squash, write the commit message, > TZ> and merge it tomorrow July 14. > > This is done. Thank you for doing this, Ted. I needed to add some Windows-specific code to get it to build on Windows. Also, the 7th test fails for me as below; any idea? Test test-gnutls-005-aead-ciphers backtrace: signal(ert-test-failed (((should (gnutls-tests-hexstring-equal input ert-fail(((should (gnutls-tests-hexstring-equal input reverse)) :for (if (unwind-protect (setq value-152 (apply fn-150 args-151)) (setq f (let (form-description-154) (if (unwind-protect (setq value-152 (app (let ((value-152 'ert-form-evaluation-aborted-153)) (let (form-descr (let ((fn-150 (function gnutls-tests-hexstring-equal)) (args-151 (li (let* ((iv (gnutls-tests-pad-or-trim iv (plist-get cplist :cipher-iv (while --dolist-tail-- (setq iv (car --dolist-tail--)) (gnutls-tests (let ((--dolist-tail-- (append ivs (list (list 'iv-auto ivsize)))) i (let* ((cplist (cdr (assq cipher (gnutls-ciphers)))) (key (gnutls-te (while --dolist-tail-- (setq key (car --dolist-tail--)) (let* ((cpli (let ((--dolist-tail-- keys) key) (while --dolist-tail-- (setq key ( (while --dolist-tail-- (setq auth (car --dolist-tail--)) (let ((--do (let ((--dolist-tail-- auths) auth) (while --dolist-tail-- (setq aut (while --dolist-tail-- (setq input (car --dolist-tail--)) (let ((--d (let ((--dolist-tail-- inputs) input) (while --dolist-tail-- (setq i (while --dolist-tail-- (setq cipher (car --dolist-tail--)) (let ((-- (let ((--dolist-tail-- ciphers) cipher) (while --dolist-tail-- (setq (let ((keys '("mykey" "mykey2")) (inputs gnutls-tests-mondo-strings) (lambda nil (let ((fn-120 (function memq)) (args-121 (list 'AEAD-cip ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test ert-run-test(#s(ert-test :name test-gnutls-005-aead-ciphers :documen ert-run-or-rerun-test(#s(ert--stats :selector t :tests [#s(ert-test ert-run-tests(t #f(compiled-function (event-type &rest event-args) # ert-run-tests-batch(nil) ert-run-tests-batch-and-exit(nil) eval((ert-run-tests-batch-and-exit nil)) command-line-1(("-L" ";." "-l" "ert" "-l" "lisp/net/gnutls-tests.el" command-line() normal-top-level() Test test-gnutls-005-aead-ciphers condition: (ert-test-failed ((should (gnutls-tests-hexstring-equal input reverse)) :form (gnutls-tests-hexstring-equal " " " ► ► ∟\231\202 \200") :value nil)) FAILED 7/7 test-gnutls-005-aead-ciphers