From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 012487b: * lisp/display-line-numbers.el (display-line-numbers-type): Autoload it. Date: Mon, 24 Jul 2017 21:37:10 +0300 Message-ID: <83inih7kbt.fsf@gnu.org> References: <20170723072843.23485.53761@vcs0.savannah.gnu.org> <20170723072844.877FD22EF0@vcs0.savannah.gnu.org> <87inijxnda.fsf@detlef> <83r2x57orp.fsf@gnu.org> <83o9s97lul.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1500923133 27687 195.159.176.226 (24 Jul 2017 19:05:33 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 24 Jul 2017 19:05:33 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jul 24 21:05:29 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dZifU-0006jT-LW for ged-emacs-devel@m.gmane.org; Mon, 24 Jul 2017 21:05:24 +0200 Original-Received: from localhost ([::1]:56525 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZifa-00056g-94 for ged-emacs-devel@m.gmane.org; Mon, 24 Jul 2017 15:05:30 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52131) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZiEW-0007ln-DJ for emacs-devel@gnu.org; Mon, 24 Jul 2017 14:37:33 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dZiER-00019M-Tp for emacs-devel@gnu.org; Mon, 24 Jul 2017 14:37:32 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:45960) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZiER-00019F-Q6; Mon, 24 Jul 2017 14:37:27 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3754 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dZiEP-0002Wn-5c; Mon, 24 Jul 2017 14:37:27 -0400 In-reply-to: (message from Stefan Monnier on Mon, 24 Jul 2017 14:16:42 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:216996 Archived-At: > From: Stefan Monnier > Cc: emacs-devel@gnu.org > Date: Mon, 24 Jul 2017 14:16:42 -0400 > > >> - the comment on the defvar isn't needed anyway: it's pretty clear why the > >> defvar is used > > It isn't clear to me, at least. > > How so? Because just _looking_ at the code doesn't explain why it's there, and its relation to autoloading is not immediately obvious. > It silences the compiler warning, just like all such (defvar foo). But this is not about silencing the compiler, this is about autoloading.