unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Robert Cochran <robert+Emacs@cochranmail.com>
Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org
Subject: Re: [PATCH] Make byte-compile-error-on-warn a safe variable for file compilation
Date: Wed, 10 Jan 2018 17:26:27 +0200	[thread overview]
Message-ID: <83inc968gs.fsf@gnu.org> (raw)
In-Reply-To: <87zi5mcjnh.fsf@cochranmail.com> (message from Robert Cochran on Tue, 09 Jan 2018 22:28:18 -0800)

> From: Robert Cochran <robert+Emacs@cochranmail.com>
> Date: Tue, 09 Jan 2018 22:28:18 -0800
> Cc: emacs-devel@gnu.org
> 
> Yeah, I noticed I forgot the autoload cookie, so I knew I had to do it
> over again anyways.
> 
> Thus, new (and hopefully) final version of the patch.
> 
> Please let me know if I need to do anything else.

I think we'd like a comment before the autoload cookie explaining why
we do things this way.

Thanks.



  reply	other threads:[~2018-01-10 15:26 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-04  9:40 [PATCH] Make byte-compile-error-on-warn a safe variable for file compilation Robert Cochran
2018-01-04 13:22 ` Noam Postavsky
2018-01-05  3:51   ` Stefan Monnier
2018-01-05  6:17   ` Robert Cochran
2018-01-05 12:05     ` Noam Postavsky
2018-01-06 22:42       ` Robert Cochran
2018-01-08 12:25         ` Noam Postavsky
2018-01-08 18:50           ` Eli Zaretskii
2018-01-09  3:42           ` Robert Cochran
2018-01-09 13:24             ` Stefan Monnier
2018-01-10  6:28               ` Robert Cochran
2018-01-10 15:26                 ` Eli Zaretskii [this message]
2018-01-10 15:57                   ` Noam Postavsky
2018-01-10 16:17                     ` Eli Zaretskii
2018-01-10 16:29                       ` Noam Postavsky
2018-01-10 19:36                         ` Eli Zaretskii
2018-01-10 19:44                           ` Noam Postavsky
2018-01-10 20:22                             ` Eli Zaretskii
2018-02-12  8:21                               ` Robert Cochran
2018-02-12 17:57                                 ` Eli Zaretskii
2018-02-13  4:49                                   ` Robert Cochran
     [not found]                                   ` <87tvulmrkd.fsf@cochranmail.com>
2018-02-16 15:53                                     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83inc968gs.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    --cc=robert+Emacs@cochranmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).