From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!.POSTED!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: emacs-26 c87d04e: Avoid aborts in 'md5'
Date: Wed, 28 Feb 2018 17:55:26 +0200
Message-ID: <83inahyuq9.fsf@gnu.org>
References: <20180227164448.16622.42058@vcs0.savannah.gnu.org>
	<20180227164448.E4B45207B1@vcs0.savannah.gnu.org>
	<87h8q15xdo.fsf@gmx.de> <mvm8tbdts67.fsf@suse.de>
	<87606h5vlm.fsf@gmx.de> <mvm4lm1tqzr.fsf@suse.de>
Reply-To: Eli Zaretskii <eliz@gnu.org>
NNTP-Posting-Host: blaine.gmane.org
X-Trace: blaine.gmane.org 1519833259 18607 195.159.176.226 (28 Feb 2018 15:54:19 GMT)
X-Complaints-To: usenet@blaine.gmane.org
NNTP-Posting-Date: Wed, 28 Feb 2018 15:54:19 +0000 (UTC)
Cc: michael.albinus@gmx.de, emacs-devel@gnu.org
To: Andreas Schwab <schwab@suse.de>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Feb 28 16:54:15 2018
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([208.118.235.17])
	by blaine.gmane.org with esmtp (Exim 4.84_2)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1er43Y-0004A4-T1
	for ged-emacs-devel@m.gmane.org; Wed, 28 Feb 2018 16:54:13 +0100
Original-Received: from localhost ([::1]:45280 helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1er45Z-0006zI-D9
	for ged-emacs-devel@m.gmane.org; Wed, 28 Feb 2018 10:56:17 -0500
Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60080)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eliz@gnu.org>) id 1er44h-0006xe-7M
	for emacs-devel@gnu.org; Wed, 28 Feb 2018 10:55:24 -0500
Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <eliz@gnu.org>) id 1er44c-00041H-GX
	for emacs-devel@gnu.org; Wed, 28 Feb 2018 10:55:23 -0500
Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:59574)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@gnu.org>)
	id 1er44c-00041C-Df; Wed, 28 Feb 2018 10:55:18 -0500
Original-Received: from [176.228.60.248] (port=3439 helo=home-c4e4a596f7)
	by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
	(Exim 4.82) (envelope-from <eliz@gnu.org>)
	id 1er44b-0002mR-MC; Wed, 28 Feb 2018 10:55:18 -0500
In-reply-to: <mvm4lm1tqzr.fsf@suse.de> (message from Andreas Schwab on Wed, 28
	Feb 2018 10:15:04 +0100)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Received-From: 2001:4830:134:3::e
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-devel/>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Original-Sender: "Emacs-devel" <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Xref: news.gmane.org gmane.emacs.devel:223172
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/223172>

> From: Andreas Schwab <schwab@suse.de>
> Cc: emacs-devel@gnu.org,  Eli Zaretskii <eliz@gnu.org>
> Date: Wed, 28 Feb 2018 10:15:04 +0100
> 
> > See bug#30627.
> 
> So the CHECK_STRING should be put in the else branch.

In general, safe code should check STRINGP before using SSDATA, so the
way I did it is safer (and also more future-proof).

> There is also a useless CHECK_BUFFER in the BUFFERP branch.

Indeed.