From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: bignum branch Date: Fri, 10 Aug 2018 08:45:13 +0300 Message-ID: <83in4iojva.fsf@gnu.org> References: <87o9fbbw1t.fsf@tromey.com> <86k1pxmvmx.fsf@gmail.com> <87efg4a9xc.fsf@tromey.com> <87a7qr8cz7.fsf@tromey.com> <86tvoy3je9.fsf@gmail.com> <86bmb0vbxf.fsf@gmail.com> <87k1pnfcg1.fsf@tromey.com> <86sh4b1833.fsf@gmail.com> <861sbgz3dm.fsf@gmail.com> <83a7q4ufxp.fsf@gnu.org> <87wot71hpb.fsf@tromey.com> <86in4rgt1m.fsf@gmail.com> <83pnyyu0k1.fsf@gnu.org> <86k1p59haq.fsf@gmail.com> <83va8osuz2.fsf@gnu.org> <87ftzrknyg.fsf@tromey.com> <87zhxwig5k.fsf@tromey.com> <86lg9gl7vy.fsf@gmail.com> <87tvo4i9em.fsf@tromey.com> <86k1ozl0yd.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1533879831 31334 195.159.176.226 (10 Aug 2018 05:43:51 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 10 Aug 2018 05:43:51 +0000 (UTC) Cc: emacs-devel@gnu.org To: Andy Moreton Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Aug 10 07:43:47 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fo0DC-00082N-9p for ged-emacs-devel@m.gmane.org; Fri, 10 Aug 2018 07:43:46 +0200 Original-Received: from localhost ([::1]:54404 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fo0FI-0007Mw-Ur for ged-emacs-devel@m.gmane.org; Fri, 10 Aug 2018 01:45:56 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41415) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fo0Eg-0007Lc-Hp for emacs-devel@gnu.org; Fri, 10 Aug 2018 01:45:19 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fo0Eb-0006ek-D1 for emacs-devel@gnu.org; Fri, 10 Aug 2018 01:45:18 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:55391) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fo0Eb-0006e6-9r; Fri, 10 Aug 2018 01:45:13 -0400 Original-Received: from [176.228.60.248] (port=2511 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fo0Ea-00040x-PZ; Fri, 10 Aug 2018 01:45:13 -0400 In-reply-to: <86k1ozl0yd.fsf@gmail.com> (message from Andy Moreton on Thu, 09 Aug 2018 21:49:46 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:228351 Archived-At: > From: Andy Moreton > Date: Thu, 09 Aug 2018 21:49:46 +0100 > > c:/msys64/mingw64/include/gmp.h has this (package version 6.1.2-1): > > /* Instantiated by configure. */ > #if ! defined (__GMP_WITHIN_CONFIGURE) > #define _LONG_LONG_LIMB 1 > #define __GMP_LIBGMP_DLL 0 > #endif > > That is suitable for linking to a static library. If I change it to look > like this: > > /* Instantiated by configure. */ > #if ! defined (__GMP_WITHIN_CONFIGURE) > #define _LONG_LONG_LIMB 1 > #define __GMP_LIBGMP_DLL 1 > #endif > > After rebuilding emacs, logcount works, and data-tests passes. I'd actually prefer us to link against GMP statically, at least on Windows, because GMP usually gets replaced when you install a new version of GCC. So linking statically runs a lower risk of a "DLL hell". It also makes the Emacs binary self-contained and more easily movable. Why is it a problem with linking statically against GMP? Could it be tat your libgmp.a is from a different GMP version, i.e. incompatible with the GMP headers you have installed? Or maybe some other optional library depends on GMP and causes conflicts? If not, I don't understand why the results should depend on how we linked the library. Thanks.