From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master build broken [macOS] Date: Mon, 03 Dec 2018 19:57:42 +0200 Message-ID: <83in0aa3xl.fsf@gnu.org> References: <83k1kqaiyd.fsf@gnu.org> <69e96cc1-935b-0a31-7de1-6eab5bb3c835@cs.ucla.edu> NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1543859870 6669 195.159.176.226 (3 Dec 2018 17:57:50 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 3 Dec 2018 17:57:50 +0000 (UTC) Cc: fgunbin@fastmail.fm, emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Dec 03 18:57:46 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gTsTZ-0001dN-US for ged-emacs-devel@m.gmane.org; Mon, 03 Dec 2018 18:57:46 +0100 Original-Received: from localhost ([::1]:51271 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gTsVg-00072z-FD for ged-emacs-devel@m.gmane.org; Mon, 03 Dec 2018 12:59:56 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46548) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gTsTi-0004GJ-Pv for emacs-devel@gnu.org; Mon, 03 Dec 2018 12:57:55 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gTsTf-00030R-MR for emacs-devel@gnu.org; Mon, 03 Dec 2018 12:57:54 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:60044) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gTsTf-00030A-HQ; Mon, 03 Dec 2018 12:57:51 -0500 Original-Received: from [176.228.60.248] (port=1450 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gTsTf-0003MO-4k; Mon, 03 Dec 2018 12:57:51 -0500 In-reply-to: <69e96cc1-935b-0a31-7de1-6eab5bb3c835@cs.ucla.edu> (message from Paul Eggert on Mon, 3 Dec 2018 08:27:20 -0800) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:231607 Archived-At: > From: Paul Eggert > Date: Mon, 3 Dec 2018 08:27:20 -0800 > Cc: Filipp Gunbin , emacs-devel@gnu.org > > Thanks for the fix; I installed it. GNU/Linux and Solaris > have SOCK_CLOEXEC and I didn't catch the typo for non-SOCK_CLOEXEC > systems like macOS. > > It is odd that even after all these years there's no way to create > sockets in a thread-safe way on macOS. This doesn't matter for > emacsclient but I assume it does matter for src/process.c. Btw, why do we want to mark the emacsclient sockets non-inheritable? According to my reading of the code, we set up the socket after we fork/exec, so socket inheritance to the Emacs daemon is not the problem, right? If so, what inheritance would be the problem? Just wondering.