From: Eli Zaretskii <eliz@gnu.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: fgunbin@fastmail.fm, emacs-devel@gnu.org
Subject: Re: master build broken [macOS]
Date: Mon, 03 Dec 2018 19:57:42 +0200 [thread overview]
Message-ID: <83in0aa3xl.fsf@gnu.org> (raw)
In-Reply-To: <69e96cc1-935b-0a31-7de1-6eab5bb3c835@cs.ucla.edu> (message from Paul Eggert on Mon, 3 Dec 2018 08:27:20 -0800)
> From: Paul Eggert <eggert@cs.ucla.edu>
> Date: Mon, 3 Dec 2018 08:27:20 -0800
> Cc: Filipp Gunbin <fgunbin@fastmail.fm>, emacs-devel@gnu.org
>
> Thanks for the fix; I installed it. GNU/Linux and Solaris <sys/socket.h>
> have SOCK_CLOEXEC and I didn't catch the typo for non-SOCK_CLOEXEC
> systems like macOS.
>
> It is odd that even after all these years there's no way to create
> sockets in a thread-safe way on macOS. This doesn't matter for
> emacsclient but I assume it does matter for src/process.c.
Btw, why do we want to mark the emacsclient sockets non-inheritable?
According to my reading of the code, we set up the socket after we
fork/exec, so socket inheritance to the Emacs daemon is not the
problem, right? If so, what inheritance would be the problem? Just
wondering.
next prev parent reply other threads:[~2018-12-03 17:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-03 11:47 master build broken [macOS] Filipp Gunbin
2018-12-03 12:33 ` Eli Zaretskii
2018-12-03 14:14 ` Filipp Gunbin
2018-12-03 16:27 ` Paul Eggert
2018-12-03 17:57 ` Eli Zaretskii [this message]
2018-12-03 18:53 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83in0aa3xl.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
--cc=fgunbin@fastmail.fm \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).