From: Eli Zaretskii <eliz@gnu.org>
To: monnier@iro.umontreal.ca
Cc: emacs-devel@gnu.org
Subject: Re: emacs-26 8f18d12: Improve documentation of decoding into a unibyte buffer
Date: Tue, 28 May 2019 22:35:44 +0300 [thread overview]
Message-ID: <83imtuz81b.fsf@gnu.org> (raw)
In-Reply-To: <83muj6z9s4.fsf@gnu.org> (message from Eli Zaretskii on Tue, 28 May 2019 21:58:03 +0300)
> Date: Tue, 28 May 2019 21:58:03 +0300
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: emacs-devel@gnu.org
>
> > From: Stefan Monnier <monnier@iro.umontreal.ca>
> > Cc: emacs-devel@gnu.org
> > Date: Tue, 28 May 2019 13:43:47 -0400
> >
> > > (let* ((str1 (string-as-multibyte (string char)))
> > > (str2 (string-as-multibyte (string char char)))
> >
> > Why on earth do we call string-as-multibyte here? AFAIK, the only cases
> > where `string` returns a unibyte string is when char <128 (it could make
> > sense to also do that for char ≥128 and <160, but we don't seem to do
> > that currently) and these are better turned into multibyte via
> > string-TO-unibyte (tho here we don't even need that, since the unibyte
> > string works just as well for what we do) than string-AS-unibyte.
> >
> > I think this is an error. The patch below seems in order.
>
> I'm not sure. Be sure to read the comments about the tricky business
> of this function, and the method it employs to solve it, and be sure
> you understand all of the subtleties there.
Btw, that function has a bug:
(encode-coding-char ?a 'ebcdic-us) => "a"
It assumes that any ASCII character is encoded into itself, i.e. that
every coding-system is ASCII-compatible, which is false.
next prev parent reply other threads:[~2019-05-28 19:35 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190525191039.14136.23307@vcs0.savannah.gnu.org>
[not found] ` <20190525191040.CCD6C207F5@vcs0.savannah.gnu.org>
2019-05-25 19:41 ` [Emacs-diffs] emacs-26 8f18d12: Improve documentation of decoding into a unibyte buffer Stefan Monnier
2019-05-25 19:59 ` Eli Zaretskii
2019-05-25 20:15 ` Eli Zaretskii
2019-05-25 21:11 ` Stefan Monnier
2019-05-25 21:27 ` Stefan Monnier
2019-05-26 2:37 ` Eli Zaretskii
2019-05-27 9:47 ` Robert Pluim
2019-05-27 12:24 ` Stefan Monnier
2019-05-27 13:02 ` Robert Pluim
2019-05-27 13:32 ` Stefan Monnier
2019-05-27 13:49 ` Robert Pluim
2019-05-27 16:53 ` Eli Zaretskii
2019-05-28 6:23 ` Robert Pluim
2019-05-28 14:57 ` Eli Zaretskii
2019-05-28 3:08 ` Stefan Monnier
2019-05-28 4:40 ` Eli Zaretskii
2019-05-28 11:55 ` Stefan Monnier
2019-05-28 15:18 ` Eli Zaretskii
2019-05-28 17:43 ` Stefan Monnier
2019-05-28 18:58 ` Eli Zaretskii
2019-05-28 19:35 ` Eli Zaretskii [this message]
2019-05-28 23:44 ` Stefan Monnier
2019-05-29 14:33 ` Eli Zaretskii
2019-05-27 16:51 ` Eli Zaretskii
2019-05-27 19:17 ` Stefan Monnier
2019-05-28 2:30 ` Eli Zaretskii
2019-05-28 2:56 ` Stefan Monnier
2019-05-28 4:17 ` Eli Zaretskii
2019-05-28 6:21 ` Robert Pluim
2019-05-28 11:53 ` Stefan Monnier
2019-05-28 11:54 ` Stefan Monnier
2019-05-28 15:11 ` Eli Zaretskii
2019-05-28 17:25 ` Stefan Monnier
2019-05-28 18:51 ` Eli Zaretskii
2019-05-28 23:39 ` Stefan Monnier
2019-05-29 2:45 ` Eli Zaretskii
2019-05-29 16:28 ` Stefan Monnier
2019-05-29 18:19 ` Eli Zaretskii
2019-05-29 18:58 ` Stefan Monnier
2019-05-29 19:09 ` Eli Zaretskii
2019-05-29 19:50 ` Stefan Monnier
2019-05-27 16:43 ` Eli Zaretskii
2019-05-27 16:42 ` Eli Zaretskii
2019-05-27 19:13 ` Stefan Monnier
2019-05-27 16:40 ` Eli Zaretskii
2019-05-27 20:17 ` Richard Stallman
2019-05-28 2:36 ` Eli Zaretskii
2019-05-28 7:06 ` Robert Pluim
2019-05-28 14:59 ` Eli Zaretskii
2019-05-28 15:11 ` Robert Pluim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83imtuz81b.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).