unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: "João Távora" <joaotavora@gmail.com>
Cc: drew.adams@oracle.com, emacs-devel@gnu.org
Subject: Re: Add user customization fido-completion-styles
Date: Tue, 02 Jun 2020 21:11:44 +0300	[thread overview]
Message-ID: <83img9cp7j.fsf@gnu.org> (raw)
In-Reply-To: <87sgfdl5jw.fsf@gmail.com> (message from João Távora on Tue, 02 Jun 2020 18:51:31 +0100)

> From: João Távora <joaotavora@gmail.com>
> Date: Tue, 02 Jun 2020 18:51:31 +0100
> Cc: emacs-devel@gnu.org
> 
>        - icomplete-post-command-hook                             2032  86%
>         - icomplete-exhibit                                      2032  86%
>          - icomplete-completions                                 2009  85%
>           - icomplete--sorted-completions                        1986  84%
>            - completion-all-sorted-completions                   1986  84%
>             - completion-all-completions                         1982  84%
>              - completion--nth-completion                        1982  84%
>               - completion--some                                 1982  84%
>                - #<compiled 0x15809f8924ad>                      1982  84%
>                 - completion-flex-all-completions                1965  84%
>                  - completion-substring--all-completions         1935  82%
>                   - completion-pcm--all-completions              1932  82%
>                    - all-completions                             1929  82%
>                     - #<compiled 0x1fe57a0ac19d>                 1929  82%
>                      - complete-with-action                      1929  82%
>                       - all-completions                            37   1%

This actually says that the time sink is complete-with-action, not
all-completions.

> As you know, all-completions is a C function.  The 1% is suspicious, I
> don't know if I should trust it.

You should trust the profile.  It works the same whether it's a C
function or a Lisp function.



  reply	other threads:[~2020-06-02 18:11 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-31 21:02 Add user customization fido-completion-styles Andrew Schwartzmeyer
2020-05-31 23:43 ` João Távora
2020-05-31 23:59   ` Dmitry Gutov
2020-06-01  0:21     ` João Távora
2020-06-01  0:37   ` Andrew Schwartzmeyer
2020-06-01  4:37     ` Andrew Schwartzmeyer
2020-06-02 11:14       ` João Távora
2020-06-02 16:14         ` Drew Adams
2020-06-02 17:51           ` João Távora
2020-06-02 18:11             ` Eli Zaretskii [this message]
2020-06-02 18:24               ` João Távora
2020-06-02 18:35                 ` Eli Zaretskii
2020-06-02 19:11                   ` João Távora
2020-06-02 19:25                     ` Eli Zaretskii
2020-06-02 20:00                       ` João Távora
2020-06-02 20:51             ` Drew Adams
2020-06-02 15:40   ` Tassilo Horn
2020-06-02 15:55     ` João Távora
2020-06-02 16:47       ` Tassilo Horn
2020-06-02 17:03         ` João Távora
2020-06-02 18:05           ` Tassilo Horn
2020-06-02 17:10         ` Tassilo Horn
2020-06-02 19:28           ` João Távora

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83img9cp7j.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=drew.adams@oracle.com \
    --cc=emacs-devel@gnu.org \
    --cc=joaotavora@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).