Byte-compilation warnings after merging eldoc changes

Byte-compilation warnings after merging eldoc changes

[Eli Zaretskii]

Like this:

  In cfengine3-mode:
  progmodes/cfengine.el:1400:41: Warning: `eldoc-documentation-function' is an
      obsolete variable (as of eldoc-1.1.0); use `eldoc-documentation-strategy'
      instead.
  progmodes/cfengine.el:1399:52: Warning: `eldoc-documentation-function' is an
      obsolete variable (as of eldoc-1.1.0); use `eldoc-documentation-strategy'
      instead.

  In python-mode:
  progmodes/python.el:5556:13: Warning: `eldoc-documentation-function' is an
      obsolete variable (as of eldoc-1.1.0); use `eldoc-documentation-strategy'
      instead.
  progmodes/python.el:5562:43: Warning: `eldoc-documentation-function' is an
      obsolete variable (as of eldoc-1.1.0); use `eldoc-documentation-strategy'
      instead.

Can these be fixed, please?

Re: Byte-compilation warnings after merging eldoc changes

[João Távora]

Eli Zaretskii <eliz@gnu.org> writes:

> Like this:
>
>   In cfengine3-mode:
>   progmodes/cfengine.el:1400:41: Warning: `eldoc-documentation-function' is an
>       obsolete variable (as of eldoc-1.1.0); use `eldoc-documentation-strategy'
>       instead.
>   progmodes/cfengine.el:1399:52: Warning: `eldoc-documentation-function' is an
>       obsolete variable (as of eldoc-1.1.0); use `eldoc-documentation-strategy'
>       instead.
>
>   In python-mode:
>   progmodes/python.el:5556:13: Warning: `eldoc-documentation-function' is an
>       obsolete variable (as of eldoc-1.1.0); use `eldoc-documentation-strategy'
>       instead.
>   progmodes/python.el:5562:43: Warning: `eldoc-documentation-function' is an
>       obsolete variable (as of eldoc-1.1.0); use `eldoc-documentation-strategy'
>       instead.
>
> Can these be fixed, please?

Yes. I'm working on it, shouldn't take long.

João

Re: Byte-compilation warnings after merging eldoc changes

[Eli Zaretskii]

> From: João Távora <joaotavora@gmail.com>
> Cc: emacs-devel@gnu.org
> Date: Wed, 08 Jul 2020 15:38:24 +0100
> 
> > Can these be fixed, please?
> 
> Yes. I'm working on it, shouldn't take long.

Thank you.

Re: Byte-compilation warnings after merging eldoc changes

[João Távora]

After analysing, I've discovered these are due to `if`
branches checking for earlier Emacs versions.

cfengine.el isn't but python.el is distributed in GNU ELPA
as a :core package which promises to support Emacs 24.1.

So while I would just delete the branch in the cfengine.el
case, I wonder what to do in the python.el case.  Can I
shoosh the byte-compiler warning of a particular type for
a particular file?

Thanks,
João

On Wed, Jul 8, 2020 at 3:48 PM Eli Zaretskii <eliz@gnu.org> wrote:
>
> > From: João Távora <joaotavora@gmail.com>
> > Cc: emacs-devel@gnu.org
> > Date: Wed, 08 Jul 2020 15:38:24 +0100
> >
> > > Can these be fixed, please?
> >
> > Yes. I'm working on it, shouldn't take long.
>
> Thank you.



-- 
João Távora

Re: Byte-compilation warnings after merging eldoc changes

[Stefan Monnier]

> So while I would just delete the branch in the cfengine.el
> case, I wonder what to do in the python.el case.  Can I
> shoosh the byte-compiler warning of a particular type for
> a particular file?

You can use `with-no-warnings` (with more recent versions, you can be
more specific thanks to `with-suppressed-warnings`).


        Stefan