From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: "modern" colors Re: Changes for emacs 28 Date: Mon, 14 Sep 2020 20:29:41 +0300 Message-ID: <83imcg9shm.fsf@gnu.org> References: <20200910102000.2t6tsju745xutg7u@Ergus> <20200910110832.ko66gqnqo4l664d6@Ergus> <20200911134225.zhnlq7cdhmu2iraj@Ergus> <20200911221435.go7b5kz2zcvxp2ft@Ergus> <20200912153723.ymnq3i5pugqf7lsy@Ergus> <871rj628mq.fsf@elephly.net> <20200912195358.3zjct7gsogjtlh3n@Ergus> <87y2lezrbp.fsf@elephly.net> <83pn6pbtni.fsf@gnu.org> <87mu1tzlxo.fsf@elephly.net> <83mu1tbp7a.fsf@gnu.org> <87h7s1zccb.fsf@elephly.net> <878sddz72o.fsf@elephly.net> <837dswbept.fsf@gnu.org> <87r1r4xq74.fsf@elephly.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14977"; mail-complaints-to="usenet@ciao.gmane.io" Cc: spacibba@aol.com, casouri@gmail.com, emacs-devel@gnu.org, ams@gnu.org, monnier@iro.umontreal.ca, ghe@sdf.org, tecosaur@gmail.com To: Ricardo Wurmus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Sep 14 19:31:13 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kHsJs-0003ng-BN for ged-emacs-devel@m.gmane-mx.org; Mon, 14 Sep 2020 19:31:12 +0200 Original-Received: from localhost ([::1]:50326 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kHsJr-0004zo-8K for ged-emacs-devel@m.gmane-mx.org; Mon, 14 Sep 2020 13:31:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47124) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kHsIP-00042E-KR for emacs-devel@gnu.org; Mon, 14 Sep 2020 13:29:41 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:56573) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kHsIO-00072I-4x; Mon, 14 Sep 2020 13:29:40 -0400 Original-Received: from [176.228.60.248] (port=3626 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kHsIL-0006h0-L3; Mon, 14 Sep 2020 13:29:38 -0400 In-Reply-To: <87r1r4xq74.fsf@elephly.net> (message from Ricardo Wurmus on Mon, 14 Sep 2020 18:45:19 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:255674 Archived-At: > From: Ricardo Wurmus > Cc: monnier@iro.umontreal.ca, spacibba@aol.com, casouri@gmail.com, > emacs-devel@gnu.org, ams@gnu.org, ghe@sdf.org, tecosaur@gmail.com > Date: Mon, 14 Sep 2020 18:45:19 +0200 > > > But is it certain that we can only do a partial job here? I don't > > think so, and the fact that we succeed in producing good results on > > other platforms is evidence to that. > > If we set the region colour according to the GTK colour theme we would > need to make sure that none of the other faces use a colour that would > be hard to distinguish from the region colour. To do a complete job > would require to set the colours in *all* faces according to the GTK > colour theme. > > Just the default colour will do nothing to remove the colour clash > between e.g. font-lock-comment-face and the region colour. How is this different from other platforms we support? This stuff does work there. It works because, as Stefan points out, Emacs adapts its face colors to the background color of the default face: we have separate sets of colors for light and dark backgrounds.