From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Always-true predicate? Date: Mon, 22 Feb 2021 17:20:44 +0200 Message-ID: <83im6kw2lv.fsf@gnu.org> References: <875z2qoqc6.fsf@gnus.org> <87eehcsal4.fsf@gmail.com> <83zh002zjm.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1940"; mail-complaints-to="usenet@ciao.gmane.io" Cc: rpluim@gmail.com, emacs-devel@gnu.org, larsi@gnus.org, rms@gnu.org To: chad Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Feb 22 16:22:37 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lED2i-0000MB-7P for ged-emacs-devel@m.gmane-mx.org; Mon, 22 Feb 2021 16:22:36 +0100 Original-Received: from localhost ([::1]:40390 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lED2h-0002wT-8t for ged-emacs-devel@m.gmane-mx.org; Mon, 22 Feb 2021 10:22:35 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59256) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lED1I-0001OF-3g for emacs-devel@gnu.org; Mon, 22 Feb 2021 10:21:08 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:55982) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lED1F-0004ck-HZ; Mon, 22 Feb 2021 10:21:07 -0500 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4899 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lED14-0001aY-Ox; Mon, 22 Feb 2021 10:20:57 -0500 In-Reply-To: (message from chad on Sun, 21 Feb 2021 21:02:43 -0800) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:265480 Archived-At: > From: chad > Date: Sun, 21 Feb 2021 21:02:43 -0800 > Cc: Robert Pluim , Lars Ingebrigtsen , Richard Stallman , > EMACS development team > > I suspect that I ran into an instance of this recently, where the helpful package (an extension that offers > expanded help functions, basically) had trouble in it's helpful-callable function with facemenu-face-menu. I > tracked the problem down to a bad interaction in helpful with this code in facemenu.el: > > (defvar facemenu-face-menu > [...]) > (defalias 'facemenu-face-menu facemenu-face-menu) > > The problem that I get is: > > Debugger entered--Lisp error: (wrong-type-argument sequencep t) > mapconcat(identity (t) " ") > s-join(" " (t)) > helpful--signature(facemenu-face-menu) > helpful-update() > helpful-callable(facemenu-face-menu) > funcall-interactively(helpful-callable facemenu-face-menu) > call-interactively(helpful-callable nil nil) > command-execute(helpful-callable) > > I'm not familiar with the (defalias 'foo foo) idiom, so maybe it should be expected to work, and it's just a bug > in helpful. (I reported it to the package maintainers already, with a note that I'd mention it here.) There are a > few other instances of in emacs that I found with a quick search, and they also cause similar trouble for > helpful. > > Is this an example of an accidental functional value, as I originally expected, or am I barking up the wrong > tree and instead just looking at a parsing bug? (My lisp is largely self taught and started with Scheme, so > these parts of elisp are murky to me.) I think it's a bug in helpful: facemenu-face-menu is a keymap, so maybe helpful isn't ready for that.