From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master c9cb59b 2/2: * etc/TODO: Entry about converting to defvar-keymap. Date: Fri, 10 Dec 2021 17:00:11 +0200 Message-ID: <83ilvwsdxg.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19570"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Stefan Kangas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Dec 10 16:01:32 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mvhOt-0004vh-OV for ged-emacs-devel@m.gmane-mx.org; Fri, 10 Dec 2021 16:01:31 +0100 Original-Received: from localhost ([::1]:56952 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mvhOs-0008Le-Sb for ged-emacs-devel@m.gmane-mx.org; Fri, 10 Dec 2021 10:01:30 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:57080) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mvhNr-0007OX-BX for emacs-devel@gnu.org; Fri, 10 Dec 2021 10:00:27 -0500 Original-Received: from [2001:470:142:3::e] (port=55236 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mvhNq-0002JV-Vb; Fri, 10 Dec 2021 10:00:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=Subject:To:From:Date:mime-version:in-reply-to: references; bh=8fQzGrPmaC36ipk1S4qJo8ioei1bhU4CnoAXPp7UqEI=; b=jpfx6KYyxEKsr3 7fi28hFS5b7HtJvfprL1iiPQ3LMM9lJ8QQIdh10qFXCy2Y5QjVJn4SEvLxkkC6hybgpsqcN2bHwo1 quvmCGXwSx5b3UVxP53YRVMgx5TGCa3jlJ+ijAlGyJKUF236YDrIWtrdfknGUDFyyF/YEq8LC7kch WcZquGafzENcwLFX2Eh4F1X+RgUfIOsb0OJO/svs92m5aGLjZF6GXGkyu4N+gEaI270pUm2nNUk/g bzWm39oDwWbm0k8drbysN5y0SjAt77O4bkjw3lNGPQpryvc2WIPgLbIZdikNHc1zH7Cj4RBHgmjmd i0QkWRn5iFXxonehZV/w==; Original-Received: from [87.69.77.57] (port=2543 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mvhNp-0004t1-80; Fri, 10 Dec 2021 10:00:26 -0500 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:281603 Archived-At: > +** Convert defvar foo-mode-map to defvar-keymap > +Verify the conversion by comparing the value of the keymap before > +converting it and after (you can see the value in 'C-h v'). Really? What are the benefits of doing such a conversion? I see only a lot of code churn and a risk of breaking things that are perfectly fine as they are. And that goes for many of the changes in this direction you made lately, btw: why are we making all those changes for purely stylistic reasons? It was always our policy not to do that except when fixing real bugs in the same area. I'd prefer that the energy and the time you have to work on Emacs would be invested to make more important changes: fixing bugs, adding new features, etc. We don't have enough resources to expend them on changes like these ones. TIA