From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master 18b680cfd1: Fix bug#52467 by adding a new custom variable 'display-comint-buffer-action' Date: Wed, 29 Dec 2021 18:57:36 +0200 Message-ID: <83ilv7jqm7.fsf@gnu.org> References: <164073060906.21430.4993248796177370312@vcs2.savannah.gnu.org> <20211228223009.6D0BAC002EE@vcs2.savannah.gnu.org> <871r1v8nhf.fsf@gnus.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33419"; mail-complaints-to="usenet@ciao.gmane.io" Cc: sdsg@amazon.com, emacs-devel@gnu.org To: Lars Ingebrigtsen , martin rudalics Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Dec 29 17:59:07 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n2cI6-0008V2-MB for ged-emacs-devel@m.gmane-mx.org; Wed, 29 Dec 2021 17:59:06 +0100 Original-Received: from localhost ([::1]:60750 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n2cI5-0004KB-Lw for ged-emacs-devel@m.gmane-mx.org; Wed, 29 Dec 2021 11:59:05 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:42564) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n2cGc-00034E-E5 for emacs-devel@gnu.org; Wed, 29 Dec 2021 11:57:35 -0500 Original-Received: from [2001:470:142:3::e] (port=44776 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n2cGb-00041v-Si; Wed, 29 Dec 2021 11:57:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=KiHsN6WGUJxS0tYjK99fAkR+06zZKq3BPdNyawXm34g=; b=PeRXkADdV8OI oUppph38z2IaGWOAmHoggaMSqB5YayNZ7XFT3wFAhdesnceq7imxwisTKZXOAclazZQmCHj4ofmj2 PivqJ2L26pvNuJAwy5KpmAgx9kcR4U89h7c38L5duFLSYdsB3Nd19XSoG281wXqkZ/at+Bv49MJp2 XcUivd4R4ZC39fp77Yaq9tXwQzOHHEmWMPI3gwjAm4Vo4f0hyFS4wgK+lmMw6mJb19wdjSvGAAPxI 2nMCmlzGb/lcqyOYSg5nTpf1o0bHBZWIpJKfomPQkbHvu1wZN0rA0crxyRVFp4txPc1edAH6oL5GH ZUysn4P6JIMc3cNTssSGXg==; Original-Received: from [87.69.77.57] (port=1501 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n2cGb-0007Kh-Nh; Wed, 29 Dec 2021 11:57:34 -0500 In-Reply-To: <871r1v8nhf.fsf@gnus.org> (message from Lars Ingebrigtsen on Wed, 29 Dec 2021 16:00:44 +0100) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:283575 Archived-At: > From: Lars Ingebrigtsen > Cc: Sam Steingold , Eli Zaretskii > Date: Wed, 29 Dec 2021 16:00:44 +0100 > > Sam Steingold writes: > > > Fix bug#52467 by adding a new custom variable 'display-comint-buffer-action' > > > > * lisp/window.el (display-comint-buffer-action): New `defcustom`, > > defaults to 'display-buffer-same-window' for backward compatibility. > > Others have noted the technical problems with this patch, but as the > discussion in bug#52467 showed, Emacs already has capabilities for > customising the behaviour here (via the general display machinery), and > adding something cross-cutting but specific to the coming-derived modes > just seems odd to me, so I'd be in favour of reverting this patch. > > Any opinions? Eli? Martin's opinions are more relevant, I think. Me, I think we have way too many display-buffer customization machinery, so much so that we are confused ourselves what we have and what we don't. But if others think this particular addition could be useful, I don't mind: a defcustom doesn't by itself do any harm, except perhaps making Emacs a tad more complex.