From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master 5743b74d4b 1/2: Improve mouse dragging Date: Thu, 12 May 2022 15:47:02 +0300 Message-ID: <83ilqaq5o9.fsf@gnu.org> References: <83sfpfp5p1.fsf@gnu.org> <87sfpfx8j8.fsf@yahoo.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="988"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu May 12 14:48:27 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1np8F0-00005k-HR for ged-emacs-devel@m.gmane-mx.org; Thu, 12 May 2022 14:48:26 +0200 Original-Received: from localhost ([::1]:42130 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1np8Ez-0004s6-3R for ged-emacs-devel@m.gmane-mx.org; Thu, 12 May 2022 08:48:25 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51748) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1np8Dc-0003LX-NV for emacs-devel@gnu.org; Thu, 12 May 2022 08:47:00 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:35500) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1np8Dc-0007nk-Bn; Thu, 12 May 2022 08:47:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=+74SFVgc3HGNemTADIXBoqRVF73Ew5SRZSCfQSDOEso=; b=hYRp2UVlmp0g pDYcXWWgXccLCUByYWhSJQZ7LLD7WlTMkwCGLAie3MmdK1NEmPBKDNARNH2xKG7LEfiCvoUEOV/rV TCQEKVwjR6WwzmsF4jRh1xMg6WNYwN6eV8uP/Ektyoo/yUyMf/4daGR+dH4kHxNuonva2SdPEYxQn Zi/vjH7Q465ZJzwcCkZPvYABWCx5MPwceBrOjo6y4wqCrfrXWR2Mk0nS5e2oEYNdFcssB+fRK4SJX pyDgUhJEimURrmI251Y1WsM7qK8xwooUzju5+zeh+uj9XvtfYlaysbPp1iKK9dhOdTLmpBe9UvF7S vIFaIo5D/aefbhSF8kruSg==; Original-Received: from [87.69.77.57] (port=3880 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1np8Db-0003Se-PG; Thu, 12 May 2022 08:47:00 -0400 In-Reply-To: <87sfpfx8j8.fsf@yahoo.com> (message from Po Lu on Thu, 12 May 2022 20:03:23 +0800) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:289679 Archived-At: > From: Po Lu > Cc: emacs-devel@gnu.org > Date: Thu, 12 May 2022 20:03:23 +0800 > > Eli Zaretskii writes: > > > Maybe I'm missing something here, but this seems to force the faces of > > the tooltip frames to follow the attributes of faces of the frame that > > is the selected frame when the tooltip is shown. Since faces are > > per-frame, why is this a good idea, and what problems does the above > > change attempt to solve? (And why do we force the border color to be > > the same as the tooltip-frame's foreground color?) > > The code is similar to that in `tooltip-show' (which the mouse dragging > code used to use), and without it the colors in the `tooltip' face are > not respected when creating the tooltip frame. Why are they not respected? I see the correct colors in the tooltips in Emacs 28, so it does seem to work. What am I missing?