From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master 513c5d827d: Use `format-prompt' in Date: Sat, 03 Sep 2022 12:15:22 +0300 Message-ID: <83ilm4om39.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31877"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Robert Pluim Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Sep 03 11:18:53 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oUPIj-00083u-78 for ged-emacs-devel@m.gmane-mx.org; Sat, 03 Sep 2022 11:18:53 +0200 Original-Received: from localhost ([::1]:57420 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oUPIi-0003WJ-6f for ged-emacs-devel@m.gmane-mx.org; Sat, 03 Sep 2022 05:18:52 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49062) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oUPFl-0002JC-DD for emacs-devel@gnu.org; Sat, 03 Sep 2022 05:15:49 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:52830) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oUPFl-0005lY-0N; Sat, 03 Sep 2022 05:15:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=Subject:To:From:Date:mime-version:in-reply-to: references; bh=z+zbtqEuDhiZ5EldCMr61ONYXnSJZHDu4STLKVM+PxE=; b=HaCtGWR7XkUAm2 rmKUMyZ7dRPCYuUy3Quled84iSD0zjO5ccQxkchYql89m9LOBAv/HTvi5+CHZABmPAGMIrPv+KrhA W+qeAyQMb4kTtg13mcBKT/K8xTJHPgCQyDsBXhGSeJ28l37xzWrjr4/jUqniyEKuZLSfXrpnig+nB 0lSQE6vUuLwUSU0oE28oIJ9wYDRxYcqQcPVdS4RmSCrJ2Y0YcVic1HKDgBPxYxK5ye4SUKdfWqZ9y Gh2ca9K1q9RWNDN4HeG8D/sH4GJ803woDsadJTR+6Yze/4l7s1Wke9kJog3S4jp4ykCo1Lx5Ds0pP Mq7LZEzapVuVAjOEkoNA==; Original-Received: from [87.69.77.57] (port=4813 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oUPFk-0001Xe-GI; Sat, 03 Sep 2022 05:15:48 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:294622 Archived-At: > branch: master > commit 513c5d827decf474f923f6f66abd2ed62e0e64f0 > Author: Robert Pluim > Commit: Robert Pluim > > Use `format-prompt' in `describe-char-fold-equivalences' > > * lisp/char-fold.el (describe-char-fold-equivalences): Use `format-prompt'. > --- > lisp/char-fold.el | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/lisp/char-fold.el b/lisp/char-fold.el > index 2ac4cb0543..43e3cd45ec 100644 > --- a/lisp/char-fold.el > +++ b/lisp/char-fold.el > @@ -439,7 +439,9 @@ non-nil, means also include partially matching ligatures and > non-canonical equivalences." > (interactive (list (ignore-errors > (read-char-by-name > - "Unicode name, single char, or hex, default all: " t)) > + (format-prompt "Unicode name, single char, or hex" > + "all") > + t)) Thanks, but is this supposed to be an improvement? Before the change, I knew what the text meant and what was the "all" part about; after the change, I don't. It's a net loss, since the code is now less readable, and in fact without either running the code or looking at what format-prompt does, one cannot understand what the prompt will say in Real Life. And don't get me started about the problems this should cause if and when we'd like to translate our prompts. IMO, format-prompt is useful where it makes the code more clear, but blindly using it everywhere is not TRT in the long run.