From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Mistakes in commit log messages Date: Sat, 15 Apr 2023 10:15:19 +0300 Message-ID: <83ildxehvc.fsf@gnu.org> References: <835ya5m4p0.fsf@gnu.org> <83v8i4arzt.fsf@gnu.org> <838rezardu.fsf@gnu.org> <319d616d-9230-0a82-331f-0f57488e4c80@gmail.com> <834jpm9s1g.fsf@gnu.org> <83v8i28b3j.fsf@gnu.org> <693285d2-e50b-289d-4f3e-ddd817ddc75b@gmail.com> <48d4dffa-cfa8-7949-3043-a1efa937902d@gmail.com> <838rew5lak.fsf@gnu.org> <5adfbf6f-fbcb-f4e8-3662-48bd5eb6a269@gmail.com> <9c8826af-a160-d36f-7577-2bc5ec0c2004@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13311"; mail-complaints-to="usenet@ciao.gmane.io" Cc: acm@muc.de, emacs-devel@gnu.org To: Jim Porter Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Apr 15 09:16:18 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pna8w-0003HC-4x for ged-emacs-devel@m.gmane-mx.org; Sat, 15 Apr 2023 09:16:18 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pna85-000336-Ow; Sat, 15 Apr 2023 03:15:25 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pna83-00032r-Fb for emacs-devel@gnu.org; Sat, 15 Apr 2023 03:15:23 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pna82-00028K-Ex; Sat, 15 Apr 2023 03:15:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=11W+lGfGkfveYin/kYVYeCjTTRlGOxpQS2+s4pG529w=; b=TE6K+GJtQjm0 OxcKpgycziwJmVE2yUR+QGko8gXcKakHGAOkKfAAhOLZ+Iz8V2lWO6ZUQrOejcgdz/R/UfS6r3HSf Fzxfg335gvCPkzuBEECFEmmX4wBPKSnlIQLB3VjEWRvfU2if5wnSDbPCwePKBtFaHTJuBV5EOPrt8 8H4nmNGoCbW+Ed4pBX+oUC5rf0V2hHMo6b9ynLNRGs1+ltBfdXJqK2oYDiDiOaxcGSNI9domBGS/Y Gvc5buVCKUITDbglgxXrcHd6crFJl87BUqP77VfvM8SmQn+3SwRHwl510OBvliXL8aLNQjLVJEYPi 2WUi5bF9+JtiX6STxQhsEw==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pna7z-0001uH-8v; Sat, 15 Apr 2023 03:15:20 -0400 In-Reply-To: <9c8826af-a160-d36f-7577-2bc5ec0c2004@gmail.com> (message from Jim Porter on Fri, 14 Apr 2023 22:45:44 -0700) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:305325 Archived-At: > Date: Fri, 14 Apr 2023 22:45:44 -0700 > From: Jim Porter > Cc: acm@muc.de, emacs-devel@gnu.org > > There's also one more commit I'm not quite sure what to do about: > 0a95a81d8d36722ccf030a6194ecd953fc257a59. It has this in the commit message: > > This fixes bug #61144. If the space around the * is "symmetric" we > leave foo > * bar unfontified, a multiplication operation. If it is > "asymmetric" we > fontify it as a pointer declaration. > > The second line of this excerpt is treated like a file entry. Maybe our > hook could allow that if it were clever enough, or maybe this is a rare > enough occurrence that we should just have committers reformat the > message slightly. The latter, IMO. There's absolutely no reason for a log message to have a '*' as the first non-whitespace character of a line. Fixing that is easy. Btw, Alan, this is a good example of your log messages, which are filled using a much larger value of fill-column that the default. The resulting ChangeLog entries appear ugly and stand out from the rest. Would you please adjust your customizations to use a smaller fill-column value, like at most 76, when writing commit log messages?