From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master d9b5f618baa 2/4: Eglot: introduce eglot-events-buffer-config Date: Wed, 27 Dec 2023 19:29:20 +0200 Message-ID: <83il4j8sgf.fsf@gnu.org> References: <83le9f8ufh.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7471"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Dec 27 18:30:24 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rIXjb-0001lo-PI for ged-emacs-devel@m.gmane-mx.org; Wed, 27 Dec 2023 18:30:23 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rIXit-0007hg-86; Wed, 27 Dec 2023 12:29:39 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rIXiq-0007hC-S5 for emacs-devel@gnu.org; Wed, 27 Dec 2023 12:29:37 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rIXiq-0004Iy-Iu; Wed, 27 Dec 2023 12:29:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=fyDgnOK2izQDjdYsu/sQEHcEW9C9oMP9F2Y2wrULDOY=; b=W+9AOchiQaCijuxBthnb jlxZKpwEj/xT/POBCm03W2MAmy/3HYD6gRcaAJToASt4Fyihz+4oR7D3woANrtcBwqa/mKDHJTs6F osEiU31ASecZXqJE2Nmux9deMILXj8A7pE8Za3C09bSJqAMNwTAWG3ezAm5lUECnZ0NEAnLobYxmb ypNWg8sDY74EYW8moVc2e8d+vL/qaC8FushMMo8BEbKIEAT71xUiYYLreJkDotds8fNbSWsL+zyo4 zbZ9n1o89SmAnR8fCSnwj4PBJqgXlCghhkcXSOxsvLnwFWO7DsFOcmLpQsN2eMEXLR1bkocBzXT6M eOFIKsQK9tDcOQ==; In-Reply-To: (message from =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= on Wed, 27 Dec 2023 17:07:22 +0000) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:314249 Archived-At: > From: João Távora > Date: Wed, 27 Dec 2023 17:07:22 +0000 > Cc: emacs-devel@gnu.org > > On Wed, Dec 27, 2023 at 4:47 PM Eli Zaretskii wrote: > > > > Since changing this defcustom needs some code to be run in order to > > make the changes effective, I wonder whether this defcustom could use > > :set to run that code automatically? > > Read above in the same diff: > > @c FIXME: Shouldn't the defcustom do this by itself using the :set > -@c attribute? > +@c attribute? Maybe not because reconnecting is a complex task. > @xref{Troubleshooting Eglot}, for when this could be useful. > > IOW Reconnecting to a server may trash useful caches, fail due > to numerous reasons, etc... We don't want to initiate it just > because a user changed a preference. Shouldn't these caveats be in the doc string, where you tell users to invoke eglot-reconnect?