From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Is it better to add treesitter modes to core? Date: Wed, 10 Jan 2024 05:29:26 +0200 Message-ID: <83il41ooh5.fsf@gnu.org> References: <87a5phiap4.fsf@posteo.net> <871qas8i6s.fsf@posteo.net> <83a5pgq9f4.fsf@gnu.org> <8734v6s3wp.fsf@posteo.net> <83wmsinuy4.fsf@gnu.org> <87le8yqmvl.fsf@posteo.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4134"; mail-complaints-to="usenet@ciao.gmane.io" Cc: dmitry@gutov.dev, stefankangas@gmail.com, emacs-devel@gnu.org, stephen_leake@stephe-leake.org To: Philip Kaludercic Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Jan 10 04:30:52 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rNPIp-0000vd-Mo for ged-emacs-devel@m.gmane-mx.org; Wed, 10 Jan 2024 04:30:51 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rNPHv-0003IL-Rk; Tue, 09 Jan 2024 22:29:55 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rNPHu-0003I6-Jf for emacs-devel@gnu.org; Tue, 09 Jan 2024 22:29:54 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rNPHt-0006Jc-BC; Tue, 09 Jan 2024 22:29:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=ucebUkbdHYy+P+VMVSqQG7XK39j+Idc1/TItK6uf5a4=; b=f0J29o9HG1lp CoGW+3JP9TrxkAVMIj8Vgx7gM//u6eoV1D07rAgHjJ7udCzf4CPbYaiM6lHdQEFLMH73noVVJ0Nh0 PYxkOjKuvdsphq/YSbE4p5BR/d6BLIIAPSzquVZYuuSJ3lzmfAoLOCWbKLW2xnAYUuEyVuUwtV0Jr NhE1hDmlUqMSe+hUB9flt6Vo1Hyx4VS5kYYy2lPBdmZa//bDhsfcRI+QCmNJH97Zii5LKFbbImDjH zIYnkB8oeMvIWkPTAfltHPJojh5P5MjLweKk7BejQmIajvUJcc0RahgqNj/XqoWv47lc8QVN3rR9Y xNPohffuc4u770sNIGkJ6A==; In-Reply-To: <87le8yqmvl.fsf@posteo.net> (message from Philip Kaludercic on Tue, 09 Jan 2024 20:21:02 +0000) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:314797 Archived-At: > From: Philip Kaludercic > Cc: dmitry@gutov.dev, stefankangas@gmail.com, emacs-devel@gnu.org, > stephen_leake@stephe-leake.org > Date: Tue, 09 Jan 2024 20:21:02 +0000 > > Eli Zaretskii writes: > > >> From: Philip Kaludercic > >> Cc: dmitry@gutov.dev, stefankangas@gmail.com, emacs-devel@gnu.org, > >> stephen_leake@stephe-leake.org > >> Date: Tue, 09 Jan 2024 19:27:50 +0000 > >> > >> Eli Zaretskii writes: > >> > >> >> From: Philip Kaludercic > >> >> Cc: Stefan Kangas , emacs-devel@gnu.org, Stephen > >> >> Leake > >> >> Date: Mon, 08 Jan 2024 06:15:07 +0000 > >> >> > >> >> > Possible grammar versioning problems. But the above should be small > >> >> > and stable enough, nor should they require many changes over the > >> >> > years. > >> >> > >> >> I don't think this has to be a problem. Last year I had suggested that > >> >> `treesit-install-language-grammar' should download release GitHub > >> >> tarballs, not just clone the repository (which requires Git, and is > >> >> prone to upstream breakage). > >> > > >> > Alas, this solution is incomplete, because some grammar libraries > >> > don't have releases at all. > >> > >> Most if not all git forges should support requesting an archive for a > >> specific commit (basically git-archive over https). For example, this > >> will provide a tarball for the current newest commit for the python > >> tree-sitter library: > >> > >> https://github.com/tree-sitter/tree-sitter-python/archive/4bfdd9033a2225cc95032ce77066b7aeca9e2efc.tar.gz > > > > I was responding to the suggestion to download release tarballs. > > Then I misunderstood you, my argument is just that we could avoid > grammar versioning issues by fetching specific revisions (be it by > commits or by releases), and that we don't even have to use git for > that. With that method, how do we know which revisions are good for us to recommend them? If a grammar library has releases, then its developers already provide us with "stable" versions, but if they don't, how do we know?