From: Eli Zaretskii <eliz@gnu.org>
To: emacs-devel@gnu.org
Subject: Include guards
Date: Thu, 08 Jul 2010 20:49:55 +0300 [thread overview]
Message-ID: <83hbk97tj0.fsf@gnu.org> (raw)
In-Reply-To: "emacs-diffs-request@gnu.org"'s message of Thu, 08 Jul 2010 02:17:28 -0400
I don't understand the removal of some of the include guards in revno
100751: the "#ifdef ..." guards were removed, but they are still used
and/or defined by src/config.h.
Examples:
. "#ifdef HAVE_CONFIG_H" was removed from bidi.c, but
src/Makefile.in still puts -DHAVE_CONFIG_H into the compilation
command line. Moreover, some source files still use it.
. "#ifdef HAVE_STRING_H" was removed, but src/config.h still uses
it.
What am I missing here? What is the plan regarding these guards?
next reply other threads:[~2010-07-08 17:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-08 17:49 Eli Zaretskii [this message]
2010-07-08 18:48 ` Include guards Dan Nicolaescu
2010-07-08 20:32 ` Eli Zaretskii
2010-07-08 23:04 ` Dan Nicolaescu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83hbk97tj0.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).