From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: rename and clean unexec.c Date: Wed, 28 Jul 2010 20:45:58 +0300 Message-ID: <83hbjjcxex.fsf@gnu.org> References: Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: dough.gmane.org 1280339200 14840 80.91.229.12 (28 Jul 2010 17:46:40 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 28 Jul 2010 17:46:40 +0000 (UTC) Cc: emacs-devel@gnu.org To: Dan Nicolaescu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jul 28 19:46:39 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OeAiE-0005Ga-07 for ged-emacs-devel@m.gmane.org; Wed, 28 Jul 2010 19:46:38 +0200 Original-Received: from localhost ([127.0.0.1]:41858 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OeAiC-0005Bm-6k for ged-emacs-devel@m.gmane.org; Wed, 28 Jul 2010 13:46:36 -0400 Original-Received: from [140.186.70.92] (port=55501 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OeAi6-0005Bh-EG for emacs-devel@gnu.org; Wed, 28 Jul 2010 13:46:31 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OeAi5-0001Bf-9I for emacs-devel@gnu.org; Wed, 28 Jul 2010 13:46:30 -0400 Original-Received: from mtaout22.012.net.il ([80.179.55.172]:56229) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OeAi1-0001Av-7o; Wed, 28 Jul 2010 13:46:25 -0400 Original-Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0L6A00D003ZEH500@a-mtaout22.012.net.il>; Wed, 28 Jul 2010 20:45:55 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.70.53.180]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0L6A00AB040I6Q90@a-mtaout22.012.net.il>; Wed, 28 Jul 2010 20:45:55 +0300 (IDT) In-reply-to: X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 (beta) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:127936 Archived-At: > From: Dan Nicolaescu > Date: Wed, 28 Jul 2010 00:38:11 -0400 > > > unexec.c is only used by MSDOS now. > It should be renamed unexecdos.c (or something like that) similar to all the other unexec files. I don't see a need to rename it. Renaming complicates VC forensics, even though bzr supports renames. This isn't the only DOS-specific file in Emacs that doesn't have "dos" as part of its name. If there's a need for a profound sign that unexec.c is used only by the DOS build, we could add a COMMENT ALL IN CAPS at its beginning. > Also it needs a bit of a cleanup given that it's only used on MSDOS. That's fine with me. > In fact almost all #ifdefs in unexec.c can be removed. Probably strictly all. The only one I'm not sure about is "#ifdef emacs" -- is some other package using this file, or do we sometimes compile in Emacs without "emacs" being defined? Anyway, I'll add to my todo to remove the ifdef's, but feel free to beat me to it, as I have much more important jobs on my plate.